Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crash when use Dehydration Leather Flask #21

Open
ZaneDragonBorn opened this issue Jan 20, 2025 · 3 comments
Open

Crash when use Dehydration Leather Flask #21

ZaneDragonBorn opened this issue Jan 20, 2025 · 3 comments

Comments

@ZaneDragonBorn
Copy link

Mod Version: 2.0.1+1.20.1
MC Version: 1.20.1
Fabric Version: 0.16.10
Java Version: 21
Dehydration Version: 1.3.6+1.20.1

Problem:
When puddles mod is running, filling up the Dehydration flask from a water block (tested with normal water block) will result in a crash-to-desktop.

Solution:
So far disabling puddles resulted in a 100% success rate in filling the flask

Crash Log:
crash-2025-01-19_20.57.48-client.txt

@Motschen
Copy link
Member

This is caused by Dehydration's Puddles compatibility being outdated on 1.20.1.
https://github.com/Globox1997/Dehydration/blob/1.20/src/main/java/net/dehydration/item/LeatherFlask.java#L170
Not much I can do about it from my side.

@Motschen
Copy link
Member

I just looked into it a bit more and it seems like I can actually fix the issue on my side.
The field type of Puddles.Puddle just needs to be changed back from PuddleBlock to Block.

@ZaneDragonBorn
Copy link
Author

I appreciate you checking! Excited to drink clean water again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants