Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Read HDFC Statements in XLS Format and convert to CSV format #2

Open
MovingToWeb opened this issue May 23, 2019 · 13 comments
Open

Read HDFC Statements in XLS Format and convert to CSV format #2

MovingToWeb opened this issue May 23, 2019 · 13 comments
Labels
enhancement New feature or request

Comments

@MovingToWeb
Copy link
Member

No description provided.

@MovingToWeb MovingToWeb added the enhancement New feature or request label May 23, 2019
@MovingToWeb
Copy link
Member Author

Sample HDFC Statement in XLS Format - https://drive.google.com/open?id=1kG7a6x2k5Hjaj5IF7Vn1QXsT-0AIpk-R

@MovingToWeb MovingToWeb changed the title Read HDFC Statements in CSV format Read HDFC Statements in XLS Format and convert to CSV format Jun 29, 2019
@varunu28
Copy link

@MovingToWeb Will start working on this. Planning to create a spring boot project for this.

@varunu28
Copy link

varunu28 commented Jul 3, 2019

@MovingToWeb I have started with implementing a parser module using the POI library. I am considering the following attributes for the CSV file. Please have a look and let me know if this fits the generic CSV format and do we have all required attributes

Bank Name, Branch Address, User Name, User Address, Cust Id, Statement Start Date, Statement End Date, Account Number, Date, Transaction, Ref No, Date, Withdraw Amount, Deposit Amount, Closing Balance

@TechSourav
Copy link

@varunu28 You may want to take the other task which says about "generic CSV model". So we can leave this task for the HDFC specific statement. Just to make sure we track it for a correct task.

@varunu28
Copy link

varunu28 commented Jul 7, 2019

@TechSourav The task which I am currently working on is to read the HDFC statement and to convert it to CSV format. Are these two separate tasks or am I missing something here?

@TechSourav
Copy link

@varunu28 Instead of going entity by entity(e.g. HDFC), should we just have a generic module for CSV format statements and pass each entity into it? So we can make use of this generic module for all the other entities. What do you say?

@varunu28
Copy link

varunu28 commented Jul 7, 2019

@TechSourav We can have a generic format for the CSV but I suppose we need to have different code modules for each of bank statements unless the bank statements in xlsx follow the same format across all the banks.

Therefore, the approach which I suggest is to have an interface for the CSV format and pass that as specific code modules to get the required attributes.

@TechSourav
Copy link

@varunu28 This seems correct. So will you write the interface for the CSV format in this same issue?

@varunu28
Copy link

varunu28 commented Jul 7, 2019

@TechSourav Yes. This is the suggested format for CSV

Bank Name, Branch Address, User Name, User Address, Cust Id, Statement Start Date, Statement End Date, Account Number, Date, Transaction, Ref No, Date, Withdraw Amount, Deposit Amount, Closing Balance

@MovingToWeb Can you please also provide some input on the format?

@anilkumarkatta204
Copy link
Contributor

@TechSourav Yes. This is the suggested format for CSV

Bank Name, Branch Address, User Name, User Address, Cust Id, Statement Start Date, Statement End Date, Account Number, Date, Transaction, Ref No, Date, Withdraw Amount, Deposit Amount, Closing Balance

@MovingToWeb Can you please also provide some input on the format?

I think, we would just duplicate the data here? each row contain same data except

Date, Transaction, Ref No, Date, Withdraw Amount, Deposit Amount, Closing Balance

I think, we should re-think and come with a better approach?

@varunu28
Copy link

varunu28 commented Jul 8, 2019

@TechSourav Yes. This is the suggested format for CSV

Bank Name, Branch Address, User Name, User Address, Cust Id, Statement Start Date, Statement End Date, Account Number, Date, Transaction, Ref No, Date, Withdraw Amount, Deposit Amount, Closing Balance

@MovingToWeb Can you please also provide some input on the format?

I think, we would just duplicate the data here? each row contain same data except

Date, Transaction, Ref No, Date, Withdraw Amount, Deposit Amount, Closing Balance

I think, we should re-think and come with a better approach?

We can have two different interfaces. One for user details and another for transactions. These two can be mapped based on the Customer ID.

@MovingToWeb
Copy link
Member Author

Sorry guys. Got busy with some personal stuff. How about a Hangout to discuss and close this one?
Saturday sounds fine?

@varunu28
Copy link

@MovingToWeb Sounds great. Let's decide up on a time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants