Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check cluster_node.is_managed before setting node as provisioner #840

Open
r0h4n opened this issue Jul 13, 2018 · 0 comments
Open

Check cluster_node.is_managed before setting node as provisioner #840

r0h4n opened this issue Jul 13, 2018 · 0 comments
Assignees

Comments

@r0h4n
Copy link
Contributor

r0h4n commented Jul 13, 2018

"Provisioner" is a node elected per gluster cluster by Tendrl, it seems currently when new un_managed nodes are lined up for expansion of cluster, they also become eligible for "Provisioner" tag election.

New un_managed nodes should not be part of "Provisioner" tag elections.

eg: Unmanaged node became "Provisioner"

{"action":"get","node":{"key":"/clusters/48558a4f-f8a0-49b4-bd2c-51878bf60b7d/nodes/c8cae4fb-841d-49bf-ad2b-e6ee6fbe855c/NodeContext","dir":true,"nodes":[{"key":"/clusters/48558a4f-f8a0-49b4-bd2c-51878bf60b7d/nodes/c8cae4fb-841d-49bf-ad2b-e6ee6fbe855c/NodeContext/updated_at","value":"2018-07-11 14:48:03.482988+00:00","modifiedIndex":36850,"createdIndex":36850},{"key":"/clusters/48558a4f-f8a0-49b4-bd2c-51878bf60b7d/nodes/c8cae4fb-841d-49bf-ad2b-e6ee6fbe855c/NodeContext/data","value":"{\"integration_id\": \"\", \"status\": \"UP\", \"tags\": \"[\\\"detected_cluster/7d0f4a7727c9c8f7e9e8f6b055f2fe14f51fc18dac8b450ab9ea4cc8d4a971b5\\\", \\\"tendrl/node_c8cae4fb-841d-49bf-ad2b-e6ee6fbe855c\\\", \\\"tendrl/integration/48558a4f-f8a0-49b4-bd2c-51878bf60b7d\\\", \\\"gluster/server\\\", \\\"provisioner/48558a4f-f8a0-49b4-bd2c-51878bf60b7d\\\", \\\"tendrl/node\\\"]\", \"sync_status\": \"done\", \"fqdn\": \"fbalak-usm2-gl5.usmqe.lab.eng.brq.redhat.com\", \"last_sync\": \"2018-07-11 14:31:29.162987+00:00\", \"first_sync_done\": \"\", \"node_id\": \"c8cae4fb-841d-49bf-ad2b-e6ee6fbe855c\", \"ipv4_addr\": \"10.37.169.132\", \"is_managed\": \"\"}","modifiedIndex":36849,"createdIndex":36849},{"key":"/clusters/48558a4f-f8a0-49b4-bd2c-51878bf60b7d/nodes/c8cae4fb-841d-49bf-ad2b-e6ee6fbe855c/NodeContext/hash","value":"4452af6e6f2201d14fd2f7e66fe594fc","modifiedIndex":36851,"createdIndex":36851},{"key":"/clusters/48558a4f-f8a0-49b4-bd2c-51878bf60b7d/nodes/c8cae4fb-841d-49bf-ad2b-e6ee6fbe855c/NodeContext/status","value":"UP","modifiedIndex":2800755,"createdIndex":2800755}],"modifiedIndex":22774,"createdIndex":22774}}

@r0h4n r0h4n self-assigned this Jul 13, 2018
r0h4n added a commit that referenced this issue Jul 13, 2018
tendrl-bug-id: #840

bugzilla: 1599634
shtripat pushed a commit to shtripat/node_agent that referenced this issue Jul 13, 2018
In case cluster is un-managed, any node ideally should be able to
claim the provisioner tag. But if cluster is managed and there are
new nodes for expansion in the cluster, only the managed nodes should
be able to claim the provisioner as new nodes if claim the same there
would be issue while expansion of the cluster.

tendrl-bug-id: Tendrl#840
bugzilla: 1599634
Signed-off-by: Shubhendu <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant