Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Days since, replace "foreigner" with non-korean #266

Open
hptk opened this issue Jul 26, 2015 · 4 comments
Open

Days since, replace "foreigner" with non-korean #266

hptk opened this issue Jul 26, 2015 · 4 comments

Comments

@hptk
Copy link
Contributor

hptk commented Jul 26, 2015

I think the title is self-explanatory.

"Foreigner" is by some concidered xenophobic etc, and the term "non-Korean" is more clear as to what we are talking about.

Also cross reference the site for other uses of "Foreign"/"Foreigner" ?

@Prillan
Copy link
Collaborator

Prillan commented Jul 29, 2015

Sounds like a good idea

@DanceParty
Copy link

Hey I am gonna see if I can deal with this one. Cool?

@DanceParty
Copy link

After browsing the website, it looks like this was already done?

@Prillan
Copy link
Collaborator

Prillan commented Mar 20, 2018

This search shows that there are still a few places left with the word foreigner: https://github.com/TheBB/aligulac/search?utf8=%E2%9C%93&q=foreigner&type= Mainly, these:

_("A foreign terran won against a Korean protoss (offline)"),
None,
Match.objects.symmetric_filter(
Q(pla__country="KR", rca="P", scb__gt=F("sca"), rcb="T") & ~Q(plb__country="KR")
).filter(offline=True).order_by("-date"),
"match"
),
(
_("A foreigner won in Proleague"),
None,
Match.objects.symmetric_filter(~Q(pla__country="KR") & Q(sca__gt=F("scb")))
.filter(eventobj__fullname__istartswith="proleague")
.order_by("-date"),
"match"
),
(
_("A foreigner won in the GSL Code S"),

Feel free to correct them.

I don't know what we should do with the translations though, perhaps just update the msgid to the new string.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants