Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider removing the private access specifier #134

Open
JasperHorn opened this issue Feb 12, 2020 · 2 comments
Open

Consider removing the private access specifier #134

JasperHorn opened this issue Feb 12, 2020 · 2 comments

Comments

@JasperHorn
Copy link
Collaborator

Private is actually implemented as protected (the two are aliases in the datatype definitions at the moment). The reason for this is that private properties don't actually make sense, because the generated class does not actually use them. The only way to make use of them would be to have child class of the generated class and use them there. But that's protected, not private...

If it's not private, why call it that?

@JasperHorn
Copy link
Collaborator Author

Do we need access specifiers at all?

I don't really see much use for them, to be honest, and just removing them simplifies the datatype format (and the code used to parse it too, of course)

@JasperHorn
Copy link
Collaborator Author

I'm leaning more and more to removing all access specifiers. And the getters and setters right along with them (leaving us with only the __set/__get properties.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant