Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Good\Manners\ResolvableCollection doesn't play nice with others #163

Open
JasperHorn opened this issue Jun 26, 2022 · 0 comments
Open

Good\Manners\ResolvableCollection doesn't play nice with others #163

JasperHorn opened this issue Jun 26, 2022 · 0 comments

Comments

@JasperHorn
Copy link
Collaborator

Basically, this class is making GoodManners something that could just as easily be built externally, because this implies the authority to do things that can only be done by one modules.

  • We're writing a Collection to each property, only to overwrite it with
    a ResolvableCollection

  • GoodManners is incompatible with other modules that also extend
    Collection, which means it's taking a role which is making it more
    than a userland (or other) module, which is not my vision for the
    modules

  • If I add notifications to the class to let IDEs know about the
    properties (which I plan to do at some point), there's simply no way
    to let the IDE know that the Storables will return
    ResolvableCollections instead of normal Collections. And any simple
    solution will run into the same problem as above: it can only be done
    by one module, which would raise GoodManners above its peers in a way
    that isn't congruent with my vision for it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant