-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add portuguese translation #224
base: master
Are you sure you want to change the base?
Add portuguese translation #224
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me! Are you gonna implement the part that allows it to switch language or leave it for another PR?
That is not in the scope of the plugin. We should only provide different languages for different players. The language switching feature should be implemented by another plugin within the server. If there are various plugins where the plugin should select a language players would have to select the language they want more than once. |
This PR will just be accepted for the beta testing. |
119892b
to
e9a42e6
Compare
Hi @TiagoFar78 , I updated the translations after your reviews and took the opportunity to change the player's color whenever it was not consistent with the other translations. |
Thanks! This PR will be the last one to be accepted before the beta testing. So that we don't have to open this PR if we need to add anything to the english translation file. |
This PR relates to #180