Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add portuguese translation #224

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

ana-mc-almeida
Copy link
Contributor

This PR relates to #180

@TiagoFar78 TiagoFar78 added documentation Improvements or additions to documentation enhancement New feature or request labels May 29, 2024
Copy link
Collaborator

@iquelli iquelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Are you gonna implement the part that allows it to switch language or leave it for another PR?

@TiagoFar78
Copy link
Owner

Are you gonna implement the part that allows it to switch language or leave it for another PR?

That is not in the scope of the plugin. We should only provide different languages for different players. The language switching feature should be implemented by another plugin within the server. If there are various plugins where the plugin should select a language players would have to select the language they want more than once.

src/main/resources/languages/portugues-pt.yml Outdated Show resolved Hide resolved
src/main/resources/languages/portugues-pt.yml Outdated Show resolved Hide resolved
src/main/resources/languages/portugues-pt.yml Outdated Show resolved Hide resolved
src/main/resources/languages/portugues-pt.yml Outdated Show resolved Hide resolved
src/main/resources/languages/portugues-pt.yml Outdated Show resolved Hide resolved
src/main/resources/languages/portugues-pt.yml Outdated Show resolved Hide resolved
src/main/resources/languages/portugues-pt.yml Outdated Show resolved Hide resolved
src/main/resources/languages/portugues-pt.yml Outdated Show resolved Hide resolved
src/main/resources/languages/portugues-pt.yml Outdated Show resolved Hide resolved
src/main/resources/languages/portugues-pt.yml Outdated Show resolved Hide resolved
@TiagoFar78 TiagoFar78 linked an issue May 29, 2024 that may be closed by this pull request
@TiagoFar78
Copy link
Owner

This PR will just be accepted for the beta testing.

@ana-mc-almeida
Copy link
Contributor Author

Hi @TiagoFar78 , I updated the translations after your reviews and took the opportunity to change the player's color whenever it was not consistent with the other translations.

@TiagoFar78
Copy link
Owner

I updated the translations after your reviews and took the opportunity to change the player's color whenever it was not consistent with the other translations.

Thanks!

This PR will be the last one to be accepted before the beta testing. So that we don't have to open this PR if we need to add anything to the english translation file.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ENH: Add portuguese translation
3 participants