Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX: Remove BukkitMessageSender methods with PrisonEscapePlayer as argument #55

Open
TiagoFar78 opened this issue Mar 23, 2024 · 3 comments
Labels
good first issue Good for newcomers problem This doesn't seem right

Comments

@TiagoFar78
Copy link
Owner

The only thing that is really needed for this class to work is the player name. The methods that don't use them should be removed and their calls should be replaced by the methods that use playerName as argument.

@TiagoFar78 TiagoFar78 added the problem This doesn't seem right label Mar 23, 2024
@TiagoFar78 TiagoFar78 added this to the v1.1 - First release milestone Mar 23, 2024
@TiagoFar78 TiagoFar78 added the good first issue Good for newcomers label Mar 29, 2024
@cati-xf
Copy link

cati-xf commented Apr 3, 2024

assign me please (note: will only try to fix in 2 weeks)

@iquelli
Copy link
Collaborator

iquelli commented Apr 3, 2024

assign me please (note: will only try to fix in 2 weeks)

New contributor 👀

@TiagoFar78
Copy link
Owner Author

Besides that I also want to move every static method to a method of the PrisonEscapePlayer class. Basically we should stop having those static methods to have methods doing the same in the PrisonEscapePlayer class.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers problem This doesn't seem right
Projects
None yet
Development

No branches or pull requests

3 participants