Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to ArrayInterface v3 #69

Open
grahamas opened this issue Mar 4, 2021 · 5 comments
Open

Update to ArrayInterface v3 #69

grahamas opened this issue Mar 4, 2021 · 5 comments

Comments

@grahamas
Copy link

grahamas commented Mar 4, 2021

This would be super useful for working with the latest LoopVectorization, which requires ArrayInterface v3.

Referenced by the auto-PRs, #64 and #66, though somehow I doubt it's that simple

(P.S. Thanks so much for this package-- I use it constantly and unfortunately you only see that when I'm opening an issue...)

@Tokazama
Copy link
Owner

Tokazama commented Mar 4, 2021

I'm actually working on that right now.

Oh, and the reason it's never a quick update with this package is because anything that I write here that is applicable to other arrays gets moved to ArrayInterface.jl as soon as I think it has a solid design. Typically that PR to ArrayInterface changes something and I end up having a breaking that is only slightly visible to most users.

@grahamas
Copy link
Author

grahamas commented Mar 4, 2021

Awesome! And totally understandable. I follow ArrayInterface, too, so I see all the work you're doing over there.

@Tokazama
Copy link
Owner

The 0.8 branch is where this all being fixed. It's taking me a while because I'm trying to clean a bunch of dead code and fix some long standing issues (mostly I hate how concatenation works in the current version, but I have to make breaking changes to fix it).

@Tokazama
Copy link
Owner

Update: I was close to a working release, but then I realized I could cut out a bunch of code (and probably improve performance and avoid bugs) if I just implemented something in ArrayInterface.jl.

@grahamas
Copy link
Author

grahamas commented Dec 1, 2021

There's some funny business going on with Revise compatibility, now--- the version of Revise that's compatible with this version of AxisIndices doesn't like to precompile on v1.7. This isn't a "please fix" nor am I 100% certain what's going on; I'm not currently actively using the package, and only noticed because AxisIndices was still installed in my default env when I booted up v1.7. Removing it fixed the problem. Just a heads up.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants