Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change confirmations for file fields break #50

Open
relwell opened this issue Jun 22, 2023 · 1 comment
Open

Change confirmations for file fields break #50

relwell opened this issue Jun 22, 2023 · 1 comment
Labels
bug Something isn't working good first issue Good for newcomers help wanted Extra attention is needed

Comments

@relwell
Copy link

relwell commented Jun 22, 2023

Describe the bug
Can't submit the confirmation form because of a javascript error:

An invalid form control with name='' is not focusable.

To Reproduce
Steps to reproduce the behavior:

  1. Trigger the confirmation flow on a model that has files, making sure you've attached a file during the process.
  2. Try to confirm. It won't work.

Expected behavior

  1. Clicking confirm should work.

Versions (please complete the following information):

  • Happens at least on latest chrome

Additional context
Adding novalidate to the form should do the trick. It's the workaround I'll be using for now.

@TrangPham
Copy link
Owner

Thanks for reporting. I'll try updating the html or scripts that a loading for the confirmation page.

A PR is also welcomed from anyone in the community. Thanks :)

@TrangPham TrangPham added bug Something isn't working help wanted Extra attention is needed good first issue Good for newcomers labels Oct 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants