Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ASN1 dependency issue: Boolean logic error using instanceof in the writeStringArray() method in lib/ber/writer.js #61

Open
welljsjs opened this issue Jan 18, 2019 · 0 comments
Open

ASN1 dependency issue: Boolean logic error using instanceof in the writeStringArray() method in lib/ber/writer.js #61

welljsjs opened this issue Jan 18, 2019 · 0 comments

Comments

@welljsjs
Copy link

This issue references the following Pull Request from the asn1 project on Github:
TritonDataCenter/node-asn1#13
Which is related to the following issue:
markabrahams/node-asn1-ber#9
and already got fixed some time ago.

However, the older version of this asn1 package is still used and so this bug is still present in the current version of sshpk.
Please update the dependencies to a newer version of asn1.
@welljsjs welljsjs changed the title ASN1 Boolean logic error using instanceof in the writeStringArray() method in lib/ber/writer.js ASN1 dependency issue: Boolean logic error using instanceof in the writeStringArray() method in lib/ber/writer.js Jan 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@welljsjs