Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Optimize the Combinatorial machine implementation #38

Open
TonyTroeff opened this issue Mar 23, 2023 · 2 comments · Fixed by #42
Open

Optimize the Combinatorial machine implementation #38

TonyTroeff opened this issue Mar 23, 2023 · 2 comments · Fixed by #42
Assignees
@TonyTroeff
Labels
enhancement A non-essential complement to a feature or a task

Comments

@TonyTroeff
Copy link
Member

TonyTroeff commented Mar 23, 2023 •
edited
Loading

Think of a way to isolate dependencies as early as possible.
@TonyTroeff TonyTroeff added the enhancement A non-essential complement to a feature or a task label Mar 23, 2023
@TonyTroeff TonyTroeff self-assigned this Mar 23, 2023
@TonyTroeff
Copy link
Member Author

Thoughts:

  1. Give priority to initialization categories (utilities) that define more demands.
  2. Keep track of the "blocked" utilities. If at any point all utilities for a given category are blocked, stop further processing.

@TonyTroeff TonyTroeff linked a pull request Aug 9, 2023 that will close this issue
Combination generation optimizations #42
Merged
@TonyTroeff
Copy link
Member Author

The first bullet was implemented in PR #42. It all started as a PoC to see if this approach will optimize the generation of combinations or not. This PoC was successful - there were even benchmark observations to prove it.

The second bullet is still not implemented.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@TonyTroeff TonyTroeff

Labels
enhancement A non-essential complement to a feature or a task
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Combination generation optimizations TryAtSoftware/CleanTests
1 participant
@TonyTroeff