-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve error message for initial_params
#772
Conversation
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Cc @willtebbutt, who has a lot of experience with good error messages and robust user interfaces. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #772 +/- ##
==========================================
+ Coverage 86.12% 86.13% +0.01%
==========================================
Files 36 36
Lines 4324 4336 +12
==========================================
+ Hits 3724 3735 +11
- Misses 600 601 +1 ☔ View full report in Codecov by Sentry. |
Pull Request Test Coverage Report for Build 12650555390Details
💛 - Coveralls |
Pull Request Test Coverage Report for Build 12656520821Details
💛 - Coveralls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this PR! It's great that people will get a clearer error message especially on this awkward bit with subsumed varnames :)
Just suggesting some very minor changes:
Co-authored-by: Penelope Yong <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
feel free to add to merge queue 😄
Address #774 partially.
This only improve the error message, and does not add support for using
OrderedDIct
for initializing.The error messages are:
Vector{Any}
NamedTuple
(keys ofNamedTuple
subsumes some variables in the model, but itself not in the model)