Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do from_internal_transform() etc. require vi and vn as arguments? #773

Closed
penelopeysm opened this issue Jan 7, 2025 · 2 comments
Closed

Do from_internal_transform() etc. require vi and vn as arguments? #773

penelopeysm opened this issue Jan 7, 2025 · 2 comments

Comments

@penelopeysm
Copy link
Member

As far as I can tell, they end up delegating to some composition of

Bijectors.bijector(dist)

and

DynamicPPL.from_vec_transform(dist)

and their inverses. I'm not sure if the codebase uses the vn and vi arguments anywhere (could have missed it).
@penelopeysm
Copy link
Member Author

penelopeysm commented Jan 7, 2025 •
edited
Loading

Ohh, vi at least is used for type dispatch. Still unsure about vn.

@penelopeysm
Copy link
Member Author

Ehehe, vn is used when dist isn't provided. Easiest issue ever to close.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@penelopeysm