Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CompatHelper: bump compat for KernelAbstractions to 0.9, (keep existing compat) #783

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

github-actions[bot]
Copy link
Contributor

This pull request changes the compat entry for the KernelAbstractions package from < 0.9.32 to < 0.9.32, 0.9.
This keeps the compat entries for earlier versions.

Note: I have not tested your package with this new compat entry.
It is your responsibility to make sure that your package tests pass before you merge this pull request.

@devmotion devmotion force-pushed the compathelper/new_version/2025-01-23-00-10-47-731-02219803879 branch from 3cc5c46 to 93dafe3 Compare January 23, 2025 00:10
Copy link

codecov bot commented Jan 23, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.72%. Comparing base (727da63) to head (93dafe3).

❗ There is a different number of reports uploaded between BASE (727da63) and HEAD (93dafe3). Click for more details.

HEAD has 21 uploads less than BASE
Flag BASE (727da63) HEAD (93dafe3)
28 7
Additional details and impacted files
@@             Coverage Diff             @@
##           master     #783       +/-   ##
===========================================
- Coverage   86.16%   73.72%   -12.45%     
===========================================
  Files          36       36               
  Lines        4301     4281       -20     
===========================================
- Hits         3706     3156      -550     
- Misses        595     1125      +530     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@coveralls
Copy link

coveralls commented Jan 23, 2025

Pull Request Test Coverage Report for Build 12919450907

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-12.5%) to 73.721%

Totals Coverage Status
Change from base Build 12908348905: -12.5%
Covered Lines: 3156
Relevant Lines: 4281

💛 - Coveralls

@penelopeysm
Copy link
Member

penelopeysm commented Jan 23, 2025

Uhh, surely this is a CompatHelper bug, in the sense that this isn't a compat bump that it should have proposed.

@penelopeysm penelopeysm marked this pull request as draft January 23, 2025 22:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants