-
Notifications
You must be signed in to change notification settings - Fork 220
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deprecate setadbackend
and update HISTORY
file
#2144
Conversation
Pull Request Test Coverage Report for Build 7230958361
💛 - Coveralls |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #2144 +/- ##
======================================
Coverage 0.00% 0.00%
======================================
Files 21 22 +1
Lines 1384 1396 +12
======================================
- Misses 1384 1396 +12 ☔ View full report in Codecov by Sentry. |
Thanks @sunxd3 -- maybe add a depreciation message for |
HISTORY.md
Outdated
# Release 0.30.0 | ||
|
||
- Replaced global variable-based AD backend mechanism with [`ADTypes.jl`](https://github.com/SciML/ADTypes.jl). Users should now specify the desired `ADType` directly in sampler constructors, e.g., `HMC(0.1, 10; adtype=AutoForwardDiff(; chunksize))`. | ||
- Deprecated and removed interface functions such as `ADBackend`, `setadbackend`, `setsafe`, `setchunksize`, and `setrdcache`. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@yebai is there a standard format for deprecation ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we can print an informational message when users call Turing.setbackend()
. This has to be defined as a function instead of HISTORY.md
. See, e.g. https://docs.julialang.org/en/v1/base/base/#Base.@deprecate
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Technically, because we are removing the functions, it doesn't count as deprecation because we skipped the deprecation step.
Currently, it will just error, which is not the worst. Maybe we can have some same-name functions that throw errors and messages with v0.30 and remove these in v0.31. Also depwarn
is probably more appropriate here because we are removing insteading of renaming.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe we can have some same-name functions that throw errors and messages with v0.30 and remove these in v0.31.
Sounds good
HISTORY
filesetadbackend
and update HISTORY
file
No description provided.