Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update for proposed DynamicPPL 0.32 #2419

Merged
merged 8 commits into from
Dec 18, 2024
Merged

Update for proposed DynamicPPL 0.32 #2419

merged 8 commits into from
Dec 18, 2024

Conversation

penelopeysm
Copy link
Member

@penelopeysm penelopeysm commented Dec 5, 2024

DPPL 0.32: TuringLang/DynamicPPL.jl#733

This PR:

  • Re-adds the tests that were straight up removed from the DPPL/Turing integration tests. Note, this basically just means that I copied test/turing/compiler.jl in DPPL to test/dynamicppl/compiler.jl here because the remaining integration tests were successfully moved to DPPL's own test suite.
  • Updates the names of DynamicPPL demo model (see link above)
  • Updates compat entries and version number

@coveralls
Copy link

coveralls commented Dec 5, 2024

Pull Request Test Coverage Report for Build 12396094525

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 78.485%

Totals Coverage Status
Change from base Build 12378413836: 0.0%
Covered Lines: 1233
Relevant Lines: 1571

💛 - Coveralls

Copy link

codecov bot commented Dec 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.62%. Comparing base (700a19a) to head (5415183).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2419   +/-   ##
=======================================
  Coverage   86.62%   86.62%           
=======================================
  Files          22       22           
  Lines        1577     1577           
=======================================
  Hits         1366     1366           
  Misses        211      211           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@penelopeysm
Copy link
Member Author

penelopeysm commented Dec 18, 2024

@yebai If you could take a look at this, once we get this merged it will clear the way for CI to run properly on the Gibbs PR :)

Right now it's timing out because of the submodel issue on DPPL (TuringLang/DynamicPPL.jl#750)

@penelopeysm penelopeysm marked this pull request as ready for review December 18, 2024 13:53
test/dynamicppl/compiler.jl Outdated Show resolved Hide resolved
test/dynamicppl/compiler.jl Outdated Show resolved Hide resolved
Copy link
Member

@yebai yebai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @penelopeysm -- I left a few minor suggestions above.

@penelopeysm
Copy link
Member Author

Thanks @yebai that's super helpful!

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@penelopeysm penelopeysm merged commit 2707d12 into master Dec 18, 2024
69 of 70 checks passed
@penelopeysm penelopeysm deleted the py/add-dppl-tests branch December 18, 2024 16:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants