-
Notifications
You must be signed in to change notification settings - Fork 219
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update for proposed DynamicPPL 0.32 #2419
Conversation
Pull Request Test Coverage Report for Build 12396094525Details
💛 - Coveralls |
9bc8f26
to
7835b7e
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2419 +/- ##
=======================================
Coverage 86.62% 86.62%
=======================================
Files 22 22
Lines 1577 1577
=======================================
Hits 1366 1366
Misses 211 211 ☔ View full report in Codecov by Sentry. |
7835b7e
to
212b27a
Compare
Including @submodel, to_submodel, link!, invlink!
b36f48c
to
3be9bf6
Compare
@yebai If you could take a look at this, once we get this merged it will clear the way for CI to run properly on the Gibbs PR :) Right now it's timing out because of the submodel issue on DPPL (TuringLang/DynamicPPL.jl#750) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @penelopeysm -- I left a few minor suggestions above.
Co-authored-by: Hong Ge <[email protected]>
Thanks @yebai that's super helpful! |
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
DPPL 0.32: TuringLang/DynamicPPL.jl#733
This PR:
test/turing/compiler.jl
in DPPL totest/dynamicppl/compiler.jl
here because the remaining integration tests were successfully moved to DPPL's own test suite.