variable naming / destructuring #2465
Merged
+33
−33
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I thought I'd put some code suggestions in a PR rather than review comments, because to suggest all these changes would have been fiddly and error-prone.
Basically, I'm proposing these changes:
_local
variable names are a bit repetitive and have lost their meaning since the loop was extracted into a function, so I got rid of most of them.varname_tuples
, as that better reflects the fact that there are two nested levels of containers (as opposed tovarnames
which suggests only one level)h, t... = container
as opposed to explicit indexing[2:end]
, as I think it's cleaner and better reflects what we're trying to do (pluck off the first element and keep the rest for later)