New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

valRegex improperly referenced #77

Open

derek-rmd opened this issue Jul 9, 2019 · 0 comments

derek-rmd commented Jul 9, 2019 •

edited

Loading

node-mongo-querystring/index.js

Line 184 in 9e3554c

ret.value = org.replace(this.valReqex, '');

should be this.valRegex not this.valReqex
but then this will replace all valid characters with '', instead of invalid chars
and is also overwritten for ^ and $ a few lines below
- this should be ret.value = `^${ret.value}`; instead
an option like escapeRegex: true might be more appropriate here
- or escapeRegexChars: /[\\^$.*+?()[\]{}|]/g, where use s.replace(this.escapeRegexChars, '\\$&') to escape (source: lodash _.escapeRegex)

The text was updated successfully, but these errors were encountered:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment