New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

better Naming for zipfiles #107

Open

qjhart opened this issue Jan 9, 2023 · 0 comments

Assignees

Member

qjhart commented Jan 9, 2023

The zipfile filename rewriting needs to be more robust. Should be more like

 this.zipName = this.rootRecord.name.replace(/[^a-zA-Z0-9]+/g, '_').replace(/^_*//).replace(/_*$//).toLowerCase().append(".zip")

In addition, there really isn't aggreeement in zipstream and tar-stream on whether the name should have it's extension included or not.

I'm sort of inclined to move the filenaming into the stream code, and use extensionless (zip|tar)Name

qjhart assigned UcDust

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment