From 8c94d723bd966a2aed4fdaac459473655e123515 Mon Sep 17 00:00:00 2001 From: Jo Dickson Date: Tue, 7 Dec 2021 17:16:43 -0500 Subject: [PATCH 1/5] Added circular clipping to faculty result thumbnails with mid-top vertical alignment --- template-faculty-search.php | 22 +++++++++++++--------- 1 file changed, 13 insertions(+), 9 deletions(-) diff --git a/template-faculty-search.php b/template-faculty-search.php index 1e9e6012..c7890990 100644 --- a/template-faculty-search.php +++ b/template-faculty-search.php @@ -125,15 +125,19 @@
- 'w-100 h-auto' - ) - ); - ?> +
+ 'media-background object-fit-cover', + 'style' => 'object-position: 50% 35%;', + 'data-object-position' => '50% 35%' + ) + ); + ?> +

From e26e6906168719763c651a16b89eb8bd908064ce Mon Sep 17 00:00:00 2001 From: Jo Dickson Date: Wed, 8 Dec 2021 09:44:16 -0500 Subject: [PATCH 2/5] Reduced faculty search result thumbnail size down to 'thumbnail' --- template-faculty-search.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/template-faculty-search.php b/template-faculty-search.php index c7890990..cc2ff268 100644 --- a/template-faculty-search.php +++ b/template-faculty-search.php @@ -129,7 +129,7 @@ 'media-background object-fit-cover', 'style' => 'object-position: 50% 35%;', From b0d691cce9979e7247b82fbdc5ff9bcf5d1c405e Mon Sep 17 00:00:00 2001 From: Jo Dickson Date: Wed, 8 Dec 2021 10:00:16 -0500 Subject: [PATCH 3/5] Updated thumbnail display on faculty profiles and faculty search results to use consistent args --- template-faculty-search.php | 5 +++-- template-parts/layout/header/content-person.php | 6 ++++-- 2 files changed, 7 insertions(+), 4 deletions(-) diff --git a/template-faculty-search.php b/template-faculty-search.php index cc2ff268..5c9ff40f 100644 --- a/template-faculty-search.php +++ b/template-faculty-search.php @@ -131,8 +131,9 @@ $post, 'thumbnail', array( - 'class' => 'media-background object-fit-cover', - 'style' => 'object-position: 50% 35%;', + 'class' => 'media-background object-fit-cover', + 'alt' => '', + 'style' => 'object-position: 50% 35%;', 'data-object-position' => '50% 35%' ) ); diff --git a/template-parts/layout/header/content-person.php b/template-parts/layout/header/content-person.php index 77b16b16..d9d5c71f 100644 --- a/template-parts/layout/header/content-person.php +++ b/template-parts/layout/header/content-person.php @@ -15,8 +15,10 @@ $obj, 'medium', array( - 'class' => 'media-background object-fit-cover', - 'alt' => '' + 'class' => 'media-background object-fit-cover', + 'alt' => '', + 'style' => 'object-position: 50% 35%;', + 'data-object-position' => '50% 35%' ) ); ?> From 982840e3ab65990bc48c622aaab8f8b6b81bc326 Mon Sep 17 00:00:00 2001 From: Jo Dickson Date: Wed, 8 Dec 2021 10:17:18 -0500 Subject: [PATCH 4/5] Added object-position for faculty typeahead suggestion thumbnails --- src/js/faculty-search-typeahead.js | 2 +- static/js/faculty-search-typeahead.min.js | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/js/faculty-search-typeahead.js b/src/js/faculty-search-typeahead.js index 20d262fd..ca7efe7a 100644 --- a/src/js/faculty-search-typeahead.js +++ b/src/js/faculty-search-typeahead.js @@ -87,7 +87,7 @@ suggestion: Handlebars.compile(`
- +
{{title.rendered}} diff --git a/static/js/faculty-search-typeahead.min.js b/static/js/faculty-search-typeahead.min.js index 20b27667..87cc2809 100644 --- a/static/js/faculty-search-typeahead.min.js +++ b/static/js/faculty-search-typeahead.min.js @@ -1 +1 @@ -!function(a){a.fn.MainSiteFacultySearch=function(e){var t=a.extend({highlight:!0,minLength:2},e),n=new Bloodhound({datumTokenizer:function(e){return Bloodhound.tokenizers.whitespace(e.title.rendered)},queryTokenizer:Bloodhound.tokenizers.whitespace,remote:{url:FACULTY_SEARCH_SETTINGS.faculty.dataEndpoint+"&search=%QUERY",wildcard:"%QUERY"},identify:function(e){return"degree_"+e.id}}),i=new Bloodhound({datumTokenizer:function(e){return Bloodhound.tokenizers.whitespace(e.name)},queryTokenizer:Bloodhound.tokenizers.whitespace,prefetch:FACULTY_SEARCH_SETTINGS.colleges.dataEndpoint,identify:function(e){return"college_"+e.id}}),e=new Bloodhound({datumTokenizer:function(e){return Bloodhound.tokenizers.whitespace(e.name)},queryTokenizer:Bloodhound.tokenizers.whitespace,remote:{url:FACULTY_SEARCH_SETTINGS.departments.dataEndpoint+"&search=%QUERY",wildcard:"%QUERY"},identify:function(e){return"department_"+e.id}});return this.typeahead(t,{name:"results-colleges",source:i.ttAdapter(),limit:3,displayKey:function(e){return a("").html(e.name).text()},templates:{header:'Faculty by College:'}},{name:"results-departments",source:e.ttAdapter(),limit:5,displayKey:function(e){return a("").html(e.name).text()},templates:{header:'Faculty by Department:'}},{name:"results-faculty",source:n.ttAdapter(),limit:5,displayKey:function(e){return a("").html(e.title.rendered).text()},templates:{suggestion:Handlebars.compile('\n
\n
\n \n
\n
\n {{title.rendered}}\n {{#if person_titles}}\n
    \n {{#each person_titles}}\n
  • {{this}}
    • \n {{/each}}\n
\n {{/if}}\n
\n
\n ')}}).on("typeahead:selected",function(e,t){var n="taxonomy"in t?t.taxonomy:"faculty";return n in FACULTY_SEARCH_SETTINGS&&FACULTY_SEARCH_SETTINGS[n].selectedAction(e,t)}),this}}(jQuery); \ No newline at end of file +!function(s){s.fn.MainSiteFacultySearch=function(e){var t=s.extend({highlight:!0,minLength:2},e),n=new Bloodhound({datumTokenizer:function(e){return Bloodhound.tokenizers.whitespace(e.title.rendered)},queryTokenizer:Bloodhound.tokenizers.whitespace,remote:{url:FACULTY_SEARCH_SETTINGS.faculty.dataEndpoint+"&search=%QUERY",wildcard:"%QUERY"},identify:function(e){return"degree_"+e.id}}),i=new Bloodhound({datumTokenizer:function(e){return Bloodhound.tokenizers.whitespace(e.name)},queryTokenizer:Bloodhound.tokenizers.whitespace,prefetch:FACULTY_SEARCH_SETTINGS.colleges.dataEndpoint,identify:function(e){return"college_"+e.id}}),e=new Bloodhound({datumTokenizer:function(e){return Bloodhound.tokenizers.whitespace(e.name)},queryTokenizer:Bloodhound.tokenizers.whitespace,remote:{url:FACULTY_SEARCH_SETTINGS.departments.dataEndpoint+"&search=%QUERY",wildcard:"%QUERY"},identify:function(e){return"department_"+e.id}});return this.typeahead(t,{name:"results-colleges",source:i.ttAdapter(),limit:3,displayKey:function(e){return s("").html(e.name).text()},templates:{header:'Faculty by College:'}},{name:"results-departments",source:e.ttAdapter(),limit:5,displayKey:function(e){return s("").html(e.name).text()},templates:{header:'Faculty by Department:'}},{name:"results-faculty",source:n.ttAdapter(),limit:5,displayKey:function(e){return s("").html(e.title.rendered).text()},templates:{suggestion:Handlebars.compile('\n
\n
\n \n
\n
\n {{title.rendered}}\n {{#if person_titles}}\n
    \n {{#each person_titles}}\n
  • {{this}}
    • \n {{/each}}\n
\n {{/if}}\n
\n
\n ')}}).on("typeahead:selected",function(e,t){var n="taxonomy"in t?t.taxonomy:"faculty";return n in FACULTY_SEARCH_SETTINGS&&FACULTY_SEARCH_SETTINGS[n].selectedAction(e,t)}),this}}(jQuery); \ No newline at end of file From 738ae546ca9d0f5f4b3a76bc330ca67c8e63d75b Mon Sep 17 00:00:00 2001 From: Jo Dickson Date: Wed, 8 Dec 2021 10:23:25 -0500 Subject: [PATCH 5/5] Adjusted object-position values --- src/js/faculty-search-typeahead.js | 2 +- static/js/faculty-search-typeahead.min.js | 2 +- template-faculty-search.php | 4 ++-- template-parts/layout/header/content-person.php | 4 ++-- 4 files changed, 6 insertions(+), 6 deletions(-) diff --git a/src/js/faculty-search-typeahead.js b/src/js/faculty-search-typeahead.js index ca7efe7a..7073da34 100644 --- a/src/js/faculty-search-typeahead.js +++ b/src/js/faculty-search-typeahead.js @@ -87,7 +87,7 @@ suggestion: Handlebars.compile(`
- +
{{title.rendered}} diff --git a/static/js/faculty-search-typeahead.min.js b/static/js/faculty-search-typeahead.min.js index 87cc2809..f2e0bf9d 100644 --- a/static/js/faculty-search-typeahead.min.js +++ b/static/js/faculty-search-typeahead.min.js @@ -1 +1 @@ -!function(s){s.fn.MainSiteFacultySearch=function(e){var t=s.extend({highlight:!0,minLength:2},e),n=new Bloodhound({datumTokenizer:function(e){return Bloodhound.tokenizers.whitespace(e.title.rendered)},queryTokenizer:Bloodhound.tokenizers.whitespace,remote:{url:FACULTY_SEARCH_SETTINGS.faculty.dataEndpoint+"&search=%QUERY",wildcard:"%QUERY"},identify:function(e){return"degree_"+e.id}}),i=new Bloodhound({datumTokenizer:function(e){return Bloodhound.tokenizers.whitespace(e.name)},queryTokenizer:Bloodhound.tokenizers.whitespace,prefetch:FACULTY_SEARCH_SETTINGS.colleges.dataEndpoint,identify:function(e){return"college_"+e.id}}),e=new Bloodhound({datumTokenizer:function(e){return Bloodhound.tokenizers.whitespace(e.name)},queryTokenizer:Bloodhound.tokenizers.whitespace,remote:{url:FACULTY_SEARCH_SETTINGS.departments.dataEndpoint+"&search=%QUERY",wildcard:"%QUERY"},identify:function(e){return"department_"+e.id}});return this.typeahead(t,{name:"results-colleges",source:i.ttAdapter(),limit:3,displayKey:function(e){return s("").html(e.name).text()},templates:{header:'Faculty by College:'}},{name:"results-departments",source:e.ttAdapter(),limit:5,displayKey:function(e){return s("").html(e.name).text()},templates:{header:'Faculty by Department:'}},{name:"results-faculty",source:n.ttAdapter(),limit:5,displayKey:function(e){return s("").html(e.title.rendered).text()},templates:{suggestion:Handlebars.compile('\n
\n
\n \n
\n
\n {{title.rendered}}\n {{#if person_titles}}\n
    \n {{#each person_titles}}\n
  • {{this}}
    • \n {{/each}}\n
\n {{/if}}\n
\n
\n ')}}).on("typeahead:selected",function(e,t){var n="taxonomy"in t?t.taxonomy:"faculty";return n in FACULTY_SEARCH_SETTINGS&&FACULTY_SEARCH_SETTINGS[n].selectedAction(e,t)}),this}}(jQuery); \ No newline at end of file +!function(s){s.fn.MainSiteFacultySearch=function(e){var t=s.extend({highlight:!0,minLength:2},e),n=new Bloodhound({datumTokenizer:function(e){return Bloodhound.tokenizers.whitespace(e.title.rendered)},queryTokenizer:Bloodhound.tokenizers.whitespace,remote:{url:FACULTY_SEARCH_SETTINGS.faculty.dataEndpoint+"&search=%QUERY",wildcard:"%QUERY"},identify:function(e){return"degree_"+e.id}}),i=new Bloodhound({datumTokenizer:function(e){return Bloodhound.tokenizers.whitespace(e.name)},queryTokenizer:Bloodhound.tokenizers.whitespace,prefetch:FACULTY_SEARCH_SETTINGS.colleges.dataEndpoint,identify:function(e){return"college_"+e.id}}),e=new Bloodhound({datumTokenizer:function(e){return Bloodhound.tokenizers.whitespace(e.name)},queryTokenizer:Bloodhound.tokenizers.whitespace,remote:{url:FACULTY_SEARCH_SETTINGS.departments.dataEndpoint+"&search=%QUERY",wildcard:"%QUERY"},identify:function(e){return"department_"+e.id}});return this.typeahead(t,{name:"results-colleges",source:i.ttAdapter(),limit:3,displayKey:function(e){return s("").html(e.name).text()},templates:{header:'Faculty by College:'}},{name:"results-departments",source:e.ttAdapter(),limit:5,displayKey:function(e){return s("").html(e.name).text()},templates:{header:'Faculty by Department:'}},{name:"results-faculty",source:n.ttAdapter(),limit:5,displayKey:function(e){return s("").html(e.title.rendered).text()},templates:{suggestion:Handlebars.compile('\n
\n
\n \n
\n
\n {{title.rendered}}\n {{#if person_titles}}\n
    \n {{#each person_titles}}\n
  • {{this}}
    • \n {{/each}}\n
\n {{/if}}\n
\n
\n ')}}).on("typeahead:selected",function(e,t){var n="taxonomy"in t?t.taxonomy:"faculty";return n in FACULTY_SEARCH_SETTINGS&&FACULTY_SEARCH_SETTINGS[n].selectedAction(e,t)}),this}}(jQuery); \ No newline at end of file diff --git a/template-faculty-search.php b/template-faculty-search.php index 5c9ff40f..429f49bf 100644 --- a/template-faculty-search.php +++ b/template-faculty-search.php @@ -133,8 +133,8 @@ array( 'class' => 'media-background object-fit-cover', 'alt' => '', - 'style' => 'object-position: 50% 35%;', - 'data-object-position' => '50% 35%' + 'style' => 'object-position: 50% 25%;', + 'data-object-position' => '50% 25%' ) ); ?> diff --git a/template-parts/layout/header/content-person.php b/template-parts/layout/header/content-person.php index d9d5c71f..bc8405e2 100644 --- a/template-parts/layout/header/content-person.php +++ b/template-parts/layout/header/content-person.php @@ -17,8 +17,8 @@ array( 'class' => 'media-background object-fit-cover', 'alt' => '', - 'style' => 'object-position: 50% 35%;', - 'data-object-position' => '50% 35%' + 'style' => 'object-position: 50% 25%;', + 'data-object-position' => '50% 25%' ) ); ?>