Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

modd_turb_cloud suppression #13

Closed
SebastienRietteMTO opened this issue Mar 13, 2023 · 2 comments
Closed

modd_turb_cloud suppression #13

SebastienRietteMTO opened this issue Mar 13, 2023 · 2 comments
Assignees
@QuentinRodier @SebastienRietteMTO
Labels
bug Something isn't working enhancement New feature or request help wanted Extra attention is needed

Comments

@SebastienRietteMTO
Copy link
Collaborator

Would it be possible to move the modd_turb_cloud keys into modd_turbn?
This would allow a better flexibility (activation of cloud mixing length modification in several models) and the suppression of the KMI argument of turb.
@SebastienRietteMTO SebastienRietteMTO added the enhancement New feature or request label May 9, 2023
QuentinRodier added a commit that referenced this issue Aug 21, 2023
@QuentinRodier
Quentin 21/08/2023: modd_turb_cloud suppression (issue #13) : keys ap…
e43073f 
…pended to NAM_TURBn + add KSPLIT->NTURBSPLIT as namelist option of NAM_TURBn
@QuentinRodier
Copy link
Collaborator

QuentinRodier commented Aug 21, 2023 •
edited
Loading

Solved in commit e43073f
options are added in modd_turbn. CTURBLEN_CLOUD (name change).
KMI is removed from argument of turb and from PHYEX%MISC as it is only used in lima call (aro_adjust_lima.F90) => I hard-coded KMI=1 in the call.

A slight problem unsolved since the changes in modd_turbn.F90 is that I have a running crash (invalid memory reference) at the writting of NAM_TURBn in modd_turbn.F90 lines :
IF(IPRINT>=3) THEN
WRITE(UNIT=KLUOUT,NML=NAM_TURBn)
ENDIF

I skipped the problem by increasing the IPRINT condition from 1 to 3 but this must be solved but I do not know how ? need help on that.
The rest of the contribution keeps the reproductibility.

@QuentinRodier QuentinRodier added bug Something isn't working help wanted Extra attention is needed labels Aug 21, 2023
@QuentinRodier
Copy link
Collaborator

Solved in 15ad8c0
IPRINT condition is now back to 1 for printing NAM_TURB

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@QuentinRodier QuentinRodier

@SebastienRietteMTO SebastienRietteMTO

Labels
bug Something isn't working enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@QuentinRodier @SebastienRietteMTO