Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Results different for rain_ice_old #24

Open
SebastienRietteMTO opened this issue May 9, 2023 · 3 comments
Open

Results different for rain_ice_old #24

SebastienRietteMTO opened this issue May 9, 2023 · 3 comments
Labels
bug Something isn't working

Comments

@SebastienRietteMTO
Copy link
Collaborator

On a small 3D case with AROME (small_2D_alt9), the results given by rain_ice_old are different between commits 37885e5 and 6e28495.
It could be due to the merging of branch 'rain_ice_old' of https://github.com/rolfhm/PHYEX or due to the branch itself.
Investigation and/or bug correction needed.

@SebastienRietteMTO SebastienRietteMTO added the bug Something isn't working label May 9, 2023
@SebastienRietteMTO
Copy link
Collaborator Author

SebastienRietteMTO commented Jun 13, 2023

Commit 8956c54 solves an issue about real*4/real*8
Commit 2116737 solves two issues introduced in the rolfhm-rain_ice_old branch
The last commit compatible with 48T3 (9164c67) once patched (leading to commit bd44ba7) reproduce correctly the results obtained with the reference version for the small_3D_alt9 case in 48T3 (obtained by commit d10ed48).

@SebastienRietteMTO
Copy link
Collaborator Author

Commit 110a5aa (obtained by application of the patch on the master branch running on CY49T0) doesn't reproduce the small_3D_alt9 case results obtained with the original CY49T0.
Is there a bugfix in PHYEX that is not included in CY49T0?
Is there an issue introduced in PHYEX when changing the reference from CY48T3 to CY49T0?

@SebastienRietteMTO
Copy link
Collaborator Author

The results from commit d10ed48 was not equal to the results from the original CY48T3 either.
It could be the reason why commit 110a5aa does not reproduce the original CY49T0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant