Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Identifying censored data #323

Closed
6 tasks
cristinamullin opened this issue Aug 8, 2023 · 3 comments · Fixed by #370
Closed
6 tasks

Identifying censored data #323

cristinamullin opened this issue Aug 8, 2023 · 3 comments · Fixed by #370
Assignees
Labels
CensoredDataSuite Good First Issue Good issue for first time contributors

Comments

@cristinamullin
Copy link
Collaborator

Is your feature request related to a problem? Please describe.

The censored data functions do not consider the user supplied MeasureQualiferCode when identifying censored data for handling and generating statistics.

Describe the solution you'd like

Add logic to the censored data functions to look at the new TADA.MeasureQualifierCode.Flag field for results categorized as "Non-Detect" or "Over-Detect" based on the user supplied MeasureQualiferCode. We may need to run TADA_FlagMeasureQualifierCode in autoclean (or within the censored data functions if the column TADA.MeasureQualifierCode.Flag does not already exist) to facilitate this.

Reminders for TADA contributors addressing this issue

New features should include all of the following work:

  • Create the function/code.

  • Document all code using comments to describe what is does.

  • Create tests in tests folder.

  • Create help file using roxygen2 above code.

  • Create working examples in help file (via roxygen2).

  • Add to appropriate vignette (or create new one).

@cristinamullin cristinamullin added the Good First Issue Good issue for first time contributors label Nov 13, 2023
@hillarymarler
Copy link
Collaborator

I'd like to work on this one. It may solve a few problems I'm encountering while working on the pathogen censored methods.

@hillarymarler hillarymarler self-assigned this Dec 8, 2023
@cristinamullin
Copy link
Collaborator Author

Great! I think this additional logic for id'ing censored data based on the MeasureQualiferCode and the TADA.MeasureQualifierCode.Flag column added by this function (https://usepa.github.io/TADA/reference/TADA_FlagMeasureQualifierCode.html) could be included in the TADA_IDCensoredData function: https://usepa.github.io/TADA/reference/TADA_IDCensoredData.html

TADA_IDCensoredData runs within autoclean (https://usepa.github.io/TADA/reference/TADA_AutoClean.html) and/or in the simple censored data handling function (https://usepa.github.io/TADA/reference/TADA_SimpleCensoredMethods.html).

@hillarymarler
Copy link
Collaborator

After running TADA_FlagMeasureQualiferCode, I used TADA.MeasureQualifierCode to identify additional censored results by filtering for "Non-Detect" and "Over_Detect". These results are then grouped with the other censored data and proceed through the rest of the function together.

Is that similar to what you had in mind? I am trying to think of any places farther along in the workflow that would need modification to include the newly identified censored results correctly, but haven't thought of any yet. I'll keep running some test data sets and see if any I spot any issues.

@hillarymarler hillarymarler linked a pull request Dec 21, 2023 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CensoredDataSuite Good First Issue Good issue for first time contributors
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants