New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CodeReview TODOs: task_lng_storage_proxy.py #48

Open

burnettear opened this issue Jan 23, 2025 · 0 comments

Assignees

Collaborator

burnettear commented Jan 23, 2025

Code review of file task_lng_storage_proxy.py

Good:

Input and output data files are present at specified filepaths
Header comment has added and made compliant
Comments explain data operations

Improvements:

Header added to be compliant
Code chunk structure adjusted for readability
Line 267 & 278 assign match_found to either True/False; however, I could not find how the object designation impacted the code. I may have missed this but wanted to check.

TODO:

@Jbollenbacher See TODO comments here in the code review branch.
Review Line 267/278
Review script and approve changes/follow-up

burnettear assigned Jbollenbacher

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment