Testing and UI update required to display effect of applying Over-Detect censor to data frame.

[JamesBisese]

Is your feature request related to a problem? Please describe.

Need to find a dataset with Over-Detects in order to test the Censored Data "Over-Detect" handling. If a user sets Under-Detect to No Change, and then runs Over-Detect censor, the result example (first 10 rows of data) does not show anything related to Over-Detect.

Describe the solution you'd like

We need an example dataset that has overdetects.
We need to censor over-detects and see the affect in the result example table displayed on the tab.

A clear and concise description of what you want to happen. If possible,
include an example of how you would like to see the code work:

library(TADAShiny)
super_cool_feature(x, y)

Describe alternatives you've considered

A clear and concise description of any alternative solutions or features
you've considered.

Additional context

Add any other context or screenshots about the feature request here.

Reminders for TADA contributors addressing this issue

New features and/or edits should include the following work:

• Create or edit the code.

• Document all code using line/inline and/or multi-line/block comments
  to describe what is does.

• Create or edit tests in tests/testthat folder to help prevent and/or
  troubleshoot potential future issues.

• If your code edits impact other functionality in the shiny
  app, ensure those are updated as well.

• Run styler::style_pkg(), devtools::document(), and devtools::check()
  and address any new notes or issues before creating a pull request.

[JamesBisese]

I can get 2 over-detects using ORG_ID 21GUAM and no date filter and Enterococcus as the only characteristic.

I can see the values in the over-detect table.
Since I really don't know exactly what I'm doing, I can only guess. The 2 places where the detection limit is now 1/2 of what it was, must be the overdetects. I'm not sure how the other values that do not change are relevant. Maybe I need to filter out the unaffected rows from the table. If 'Original Detection Limit Value' is equal to 'Estimated Detection Limit Value' then do not show that row in the table.

[JamesBisese]

I added a line to filter data
dat <- dat %>% filter(DetectionQuantitationLimitMeasure.MeasureValue != TADA.ResultMeasureValue)
It revealed more issues that I knew were happening, but that isn't bad.

[JamesBisese]

During testing I loaded data for 21GUAM Enterococcus, and then stayed in the same session and went back to Load tab and changed the ORG_ID to 21NYBCH.
Your dataset contains 146,646 unique results from 480 monitoring location(s) and 1 unique organization(s).
But now I see that my Censor Data filters are still set from earlier.

When reloading new data I need to clear the Censor Data filter and 'disable/enable' settings.

[cristinamullin]

@JamesBisese I added two columns to the table in the PR so that a user can see how the detection limit is described (as an over or under detect) in "ResultDetectionConditionText" and "DetectionQuantitationLimitTypeName": #197 and https://github.com/USEPA/TADAShiny/pull/197/files

I also made edits so all results can be reviewed if needed (not just 10).

I think there are pros and cons to filter vs. not filter this table. Can the table filtering you are adding be made optional for users?