Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-running 1. Load > Query Now results in instable session state #196

Open
5 tasks
JamesBisese opened this issue Dec 23, 2024 · 0 comments
Open
5 tasks

Comments

@JamesBisese
Copy link
Collaborator

JamesBisese commented Dec 23, 2024

Describe the bug

If a user Queries and Flags and Censors data, and then returns to the 1/ Load tab and changes anything and re-runs Query then the UI is not reset to original state. Tabs and Buttons are active that need to be inactive.

To Reproduce

Steps to reproduce the behavior:

1. Query data using ORG_ID 21GUAM, no dates, Characteristic Enterococcus. Click Run Query

2. Click on '3. Flag' and then hit the Flag button

3. Click on '5. Censored Data' and turn the options to Non-Detect Handling Method No Change
and Over-Detect Handling Method to Multiple Limit by X and set x to 0.25

4. Click on 'Apply Methods to Dataset' button

5. Return to tab '1. Load' and add a second ORG_ID 21GUBCH

6. Click Run Query.

7. Click the '5. Censored Data' tab

8. The web application hits a fatal error
Error: (converted from warning) Error in : (converted from warning) Error in dplyr::group_by: Must group by variables found in .data.
✖ Column TADA.CensoredData.Flag is not found.

8. scroll down and see that the 'Apply Methods to Dataset' button is still disabled, and the 'Undo Method Application' is active.

Please include your Water Quality Portal data query inputs from the Load
data tab:

If applicable, include code to reproduce the behavior:

library(TADAShiny)
TADAShiny::run_app()

Expected behavior

The Method Application UI widgets should be reset to original settings when 'Query Data' is run.

Screenshots

If applicable, add screenshots to help explain your problem.

Additional context

Add any other context about the problem here.

Reminders for TADA contributors addressing this issue

Bug fixes should include the following work:

  • Create or edit the code.

  • Document all code using line/inline and/or multi-line/block comments
    to describe what is does.

  • Create or edit tests in tests/testthat folder to help prevent and/or
    troubleshoot potential future issues.

  • If your code edits impact other functionality in the shiny
    app, ensure those are updated as well.

  • Run styler::style_pkg(), devtools::document(), and devtools::check()
    and address any new notes or issues before creating a pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant