You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
If a user Queries and Flags and Censors data, and then returns to the 1/ Load tab and changes anything and re-runs Query then the UI is not reset to original state. Tabs and Buttons are active that need to be inactive.
To Reproduce
Steps to reproduce the behavior:
1. Query data using ORG_ID 21GUAM, no dates, Characteristic Enterococcus. Click Run Query
2. Click on '3. Flag' and then hit the Flag button
3. Click on '5. Censored Data' and turn the options to Non-Detect Handling Method No Change
and Over-Detect Handling Method to Multiple Limit by X and set x to 0.25
4. Click on 'Apply Methods to Dataset' button
5. Return to tab '1. Load' and add a second ORG_ID 21GUBCH
6. Click Run Query.
7. Click the '5. Censored Data' tab
8. The web application hits a fatal error
Error: (converted from warning) Error in : (converted from warning) Error in dplyr::group_by: Must group by variables found in .data.
✖ Column TADA.CensoredData.Flag is not found.
8. scroll down and see that the 'Apply Methods to Dataset' button is still disabled, and the 'Undo Method Application' is active.
Please include your Water Quality Portal data query inputs from the Load
data tab:
If applicable, include code to reproduce the behavior:
library(TADAShiny)
TADAShiny::run_app()
Expected behavior
The Method Application UI widgets should be reset to original settings when 'Query Data' is run.
Screenshots
If applicable, add screenshots to help explain your problem.
Additional context
Add any other context about the problem here.
Reminders for TADA contributors addressing this issue
Bug fixes should include the following work:
Create or edit the code.
Document all code using line/inline and/or multi-line/block comments
to describe what is does.
Create or edit tests in tests/testthat folder to help prevent and/or
troubleshoot potential future issues.
If your code edits impact other functionality in the shiny
app, ensure those are updated as well.
Run styler::style_pkg(), devtools::document(), and devtools::check()
and address any new notes or issues before creating a pull request.
The text was updated successfully, but these errors were encountered:
Describe the bug
If a user Queries and Flags and Censors data, and then returns to the 1/ Load tab and changes anything and re-runs Query then the UI is not reset to original state. Tabs and Buttons are active that need to be inactive.
To Reproduce
Steps to reproduce the behavior:
1. Query data using ORG_ID 21GUAM, no dates, Characteristic Enterococcus. Click Run Query
2. Click on '3. Flag' and then hit the Flag button
3. Click on '5. Censored Data' and turn the options to Non-Detect Handling Method No Change
and Over-Detect Handling Method to Multiple Limit by X and set x to 0.25
4. Click on 'Apply Methods to Dataset' button
5. Return to tab '1. Load' and add a second ORG_ID 21GUBCH
6. Click Run Query.
7. Click the '5. Censored Data' tab
8. The web application hits a fatal error
Error: (converted from warning) Error in : (converted from warning) Error in dplyr::group_by: Must group by variables found in
.data
.✖ Column
TADA.CensoredData.Flag
is not found.8. scroll down and see that the 'Apply Methods to Dataset' button is still disabled, and the 'Undo Method Application' is active.
Please include your Water Quality Portal data query inputs from the Load
data tab:
If applicable, include code to reproduce the behavior:
Expected behavior
The Method Application UI widgets should be reset to original settings when 'Query Data' is run.
Screenshots
If applicable, add screenshots to help explain your problem.
Additional context
Add any other context about the problem here.
Reminders for TADA contributors addressing this issue
Bug fixes should include the following work:
Create or edit the code.
Document all code using line/inline and/or multi-line/block comments
to describe what is does.
Create or edit tests in tests/testthat folder to help prevent and/or
troubleshoot potential future issues.
If your code edits impact other functionality in the shiny
app, ensure those are updated as well.
Run styler::style_pkg(), devtools::document(), and devtools::check()
and address any new notes or issues before creating a pull request.
The text was updated successfully, but these errors were encountered: