Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Required flags shouldn't have a dial at all #89

Closed
6 tasks
ehinman opened this issue Aug 23, 2023 · 0 comments · Fixed by #124
Closed
6 tasks

Required flags shouldn't have a dial at all #89

ehinman opened this issue Aug 23, 2023 · 0 comments · Fixed by #124
Assignees
@triphook

Comments

@ehinman
Copy link
Contributor

ehinman commented Aug 23, 2023 •
edited by cristinamullin
Loading

Describe the bug

Dial for required flags is grayed out but people may still want to try to turn the dial. Recommend removing the dial and instead say "Not Applicable".

Reminders for TADA contributors addressing this issue

New features should include all of the following work:

  • Create the function/code.

  • Document all code using comments to describe what is does.

  • Create tests in tests folder.

  • Create help file using roxygen2 above code.

  • Create working examples in help file (via roxygen2).

  • Add to appropriate vignette (or create new one).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@triphook triphook

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

replace required flag toggles with "n/a" USEPA/TADAShiny
2 participants
@triphook @ehinman