Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MeasureQualifierCode definitions #92

Closed
5 tasks
cristinamullin opened this issue Sep 5, 2023 · 2 comments
Closed
5 tasks

MeasureQualifierCode definitions #92

cristinamullin opened this issue Sep 5, 2023 · 2 comments
Assignees

Comments

@cristinamullin
Copy link
Collaborator

Is your feature request related to a problem? Please describe.

Users currently need to know the definitions of each MeasureQualifierCode to filter. We can provide those within the application.

image

Describe the solution you'd like

Leverage TADA WQXMeasureQualifierCodeRef.csv to add definitions for each MeasureQualifierCode. Use TADA_GetMeasureQualifierCodeRef() (https://usepa.github.io/TADA/reference/TADA_GetMeasureQualifierCodeRef.html) to get table.

Describe alternatives you've considered

We could just provide a link to the WQX domain list. https://www.epa.gov/waterdata/storage-and-retrieval-and-water-quality-exchange-domain-services-and-downloads
ResultMeasureQualifier (ZIP) | (XML)| (CSV)

Reminders for TADA contributors addressing this issue

New features should include all of the following work:

  • Create the function/code.

  • Document all code using comments to describe what is does.

  • Create tests in tests folder.

  • Create help file using roxygen2 above code.

  • Create working examples in help file (via roxygen2).

@cristinamullin
Copy link
Collaborator Author

cristinamullin commented Sep 15, 2023

New solution: remove this from filter tab. We now have a TADA flag for this element. Instead, in the TADA package create a new column with the definition as part of this flag function. That definition should be the removal reason for anything flagged for removal by this flag.

@cristinamullin cristinamullin self-assigned this Oct 16, 2023
@cristinamullin
Copy link
Collaborator Author

Removing this issue here & including an issue for the TADA package instead: USEPA/EPATADA#358

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant