Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feedback from WDIB #97

Closed
cristinamullin opened this issue Sep 7, 2023 · 3 comments
Closed

Feedback from WDIB #97

cristinamullin opened this issue Sep 7, 2023 · 3 comments

Comments

@cristinamullin
Copy link
Collaborator

cristinamullin commented Sep 7, 2023

Attaching feedback from WDIB internal review

@cristinamullin cristinamullin self-assigned this Oct 16, 2023
@cristinamullin
Copy link
Collaborator Author

Regarding adding counts to the data retrieval, see web services documentation: https://www.waterqualitydata.us/data/swagger-ui/index.html?docExpansion=none&url=/data/v3/api-docs#/Result/resultPostCountRequest

@cristinamullin cristinamullin removed their assignment Jun 4, 2024
@JamesBisese
Copy link
Collaborator

JamesBisese commented Jun 5, 2024

I think 'warning' the user about the number of results using a pop-up before loading into TADA is in line with what WQP does, and would save a huge amount of bandwidth. This is in Kevin's comments. Here is the WQP 'warning' pop-up.

image

@cristinamullin
Copy link
Collaborator Author

I am creating separate issues for remaining tasks identified from Kiki & Kevin's review:
#159
#158
#160

I already addressed Kevin's suggestion to switch the bar chart axis in cm-release-review-2 branch and will merge in next week. Already addressed some of Kiki's comments there as well. Remaining ones are now in the issues above.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants