-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Components and Containers #56
Comments
I think timer should not be maintained in the container else a new store will be created every second. |
what about progress component?? I think it will be good to display progression like
??
|
@PN1019 Yes it could be done but in our current UI designs we have not added progress bar because the number questions (like you said 20) is still debatable and not decided. |
@twishasaraiya it doesn't matter how many numbers of questions you are planning to move with it totally depends on your call well since you are specifying that UI designs don't have progress bar as of now this can also be included in next version if you don't want to make any changes in UI now..but I think it will good to go with Progression even now ... Also, how are you planning to move to next question?via NextButton or Timer ?? I think NextButton component should be there since many players can answer the question before the time they need not have to wait for the timer to finish off..!!ok...just checkout NextButton is there in UI design so this will be good to go with ...what say?? |
@PN1019 I think the progress bar can be included in the next version since now our focus to make it a PWA first. Also, I agree with you that there should be a I am assuming you are talking about |
@twishasaraiya yes I am talking about CorrectAnswer and WrongAnswer. |
Okay let's have one |
The design assets only seem to have mobile UI mockups. Any thoughts or opinions on how it should scale on bigger screen sizes? |
@drenther Thanks for asking since I guess many people would have the same doubt.I think @ayushdev and @varundevpro will be able to explain better since they have designed the mockups. |
@drenther We can use custom media queries for small, mid, and large screen sizes. As the containers inside pages are very simple, I think they will be handled easily. |
@twishasaraiya I would like to work on this let me know what I can take up ?? Anyone already working on components?? |
@ayushdev I did not mean the implementation details. Of course, we will use custom media queries. I meant how It should look on tablet and desktops should also be represented in designs for the sake of seamless implementation when different people implement different components. So that the design choices won't be made by everyone on their own but inferred from the design mockups. To look at it more practically - Any thoughts? |
@drenther I get your point. I thought I would create some but not all samples. As Varun is not available and I too am overwhelmed by academic work, this thing is somewhat overwhelming for me. If you know any prototyping tools, maybe you could help me out. |
@PN1019 So I am assigning this issue to you. You can work on the main |
I am interesting to work on QuoteAndOptions component.Can i start work on this. |
@suhasbansude Since I have asked @PN1019 about it. Let's wait for the reply. If he is not working on QuoteandOption then you can definitely take it up. |
@ayushdev Yes, sure. I know my way around some of them. Let me know how you plan to work on this and how can I be of any help. |
@suhasbansude if you wanna take QuoteAndOptions take that up...it just fine with..me.... @twishasaraiya.... thanks...I will work on button components if I am not wrong you mean NextButton ??? If that's the case I am good to go with it.....!!! |
Okay so @suhasbansude you are taking up Also refer to the If you have any doubts please free to ask them. |
@twishasaraiya Can I work on the HowToPlay Instruction Component |
@skarthikeyan96 Yes you can work on it. |
@twishasaraiya you haven't specified any testing guidelines for react components?? It would be good if you will make it standard since many people will be working on components...!! |
I am extremely sorry for late reply as I was busy with college placements and practicals. I request you all to submit PR by Sunday or before as soon as possible. |
@twishasaraiya I can work on the Timer if no one is working on it. |
Yes please @anantoghosh you can work on it. |
Hi, will be working on the Score Component. |
I'll be working on timer and score component |
@Rohanhacker I m sorry but others are already working on it. |
damm |
is anything available ? |
Nope as of now. You could work on homepage if you want with @ayushdev. |
Static data will be passed in for now and redux configuration will be done later.
Basic Flow
Components(props)
Containers
Besides these, there is Login/SignUp Component. You can refer this Issue
Please let me know your suggestions and opinions here.
The text was updated successfully, but these errors were encountered: