Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unit Test: setting properies on a boxed PsyColor/Make PsyColor a boxed type #134

Open
maartenuni opened this issue Nov 5, 2024 · 1 comment
Open

Unit Test: setting properies on a boxed PsyColor/Make PsyColor a boxed type #134

maartenuni opened this issue Nov 5, 2024 · 1 comment
Assignees
@maartenuni
Labels
enhancement New feature or request

Comments

@maartenuni
Copy link
Contributor

In test_image.c:140 the unit test are setting properties on a PsyColor, which is a boxed structure, not a GObject.
@maartenuni maartenuni added the invalid This doesn't seem right label Nov 5, 2024
@maartenuni maartenuni self-assigned this Nov 5, 2024
@maartenuni maartenuni added enhancement New feature or request and removed invalid This doesn't seem right labels Feb 5, 2025
@maartenuni
Copy link
Contributor Author

The comment above is wrong. PsyColor is a GObject. However, it is nice to convert it to a boxed structure, as it is too simple to be an object. This might make it cheaper to create them and make psylib a bit faster.

So I would like to make this a new feature request in order to make all PsyColors a boxed type

@maartenuni maartenuni changed the title Unit Test: setting properies on a boxed PsyColor Unit Test: setting properies on a boxed PsyColor/Make PsyColor a boxed type Feb 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@maartenuni maartenuni

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@maartenuni