Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Buttons on a toolbar have an ugly border selection box #32

Open
djensen47 opened this issue Nov 23, 2017 · 5 comments
Open

Buttons on a toolbar have an ugly border selection box #32

djensen47 opened this issue Nov 23, 2017 · 5 comments

Comments

@djensen47
Copy link
Contributor

The border box button seems to also be in the toolbar.

  1. Add a button to a toolbar
  2. Click the button

Result: selection border around the button

mdc-toolbar-button-bug

@Ullfis
Copy link
Owner

Ullfis commented Nov 24, 2017

This also happens when not using Aurelia and the bridge. Try using a tag instead.

<mdc-toolbar-section end="true">
  <a href="#" class="mdc-toolbar__icon material-icons" mdc-ripple>arrow_downward</a>
  <button class="mdc-toolbar__icon"><i class="material-icons" mdc-ripple>arrow_upward</i></button>
  <span class="mdc-toolbar__icon material-icons" mdc-ripple>delete</span>
</mdc-toolbar-section>

@Ullfis
Copy link
Owner

Ullfis commented Dec 15, 2017

Hmmm... I made a gist and can not see the border selection box..

The gist is using bundled css from material-components-web while bridge documentation is using scss build. What is your project using?

@Ullfis
Copy link
Owner

Ullfis commented Dec 15, 2017

A new project with bundled css and a new project with scss build do not give that border. I also tried to copy scss from the bridge project without getting the border.

But the document in bridge project does. strange...

@djensen47
Copy link
Contributor Author

We're using scss for our project.

@djensen47
Copy link
Contributor Author

I'm finally on the latest aurelia-mdc-bridge and I'm still seeing the issue. Even weirder, the border color changed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants