Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sending notifications: plugins or glue-service? #43

Closed
hmpf opened this issue Jun 10, 2020 · 2 comments
Closed

Sending notifications: plugins or glue-service? #43

hmpf opened this issue Jun 10, 2020 · 2 comments
Labels
discussion Requires developer feedback/discussion before implementation

Comments

@hmpf
Copy link
Contributor

hmpf commented Jun 10, 2020

Should the code sending notifications be hosted inside the backend or live as their own services? That is: if hosted in the backend, a plugin system is needed to add more notification recipient types. If hosted as microservices, we need to define a push API that the backend pushes to a microservice that then translates this to SMS/teams/email/rt/what have you

@hmpf hmpf added the discussion Requires developer feedback/discussion before implementation label Jun 17, 2020
@hmpf
Copy link
Contributor Author

hmpf commented Aug 19, 2020

Right now, we support email and SMS, with a simple plugin-system. A notification is sent by its own process and does not affect the rest of the backend. The actual code to do this is so light that at the moment, a separate microservice for this would very much be overkill.

@hmpf
Copy link
Contributor Author

hmpf commented Sep 15, 2020

Currently included with a plugin.system, but see #121. Closing.

@hmpf hmpf closed this as completed Sep 15, 2020
hmpf added a commit to hmpf/Argus that referenced this issue Nov 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
discussion Requires developer feedback/discussion before implementation
Projects
None yet
Development

No branches or pull requests

1 participant