Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Armor from Flans Mod turns brown on CustomNPC's #228

Open
Bu0ngiorno opened this issue Jan 20, 2025 · 4 comments
Open

Armor from Flans Mod turns brown on CustomNPC's #228

Bu0ngiorno opened this issue Jan 20, 2025 · 4 comments

Comments

@Bu0ngiorno
Copy link

I noticed a bug some time ago in the latest version of Flans Mod Ultimate Stability Edition where the armor just turns brown on NPC's for some reason (in this case CustomNPC's plus), so i decided to post the issue on the GitHub page by myself. Afaik, it can be "fixed" by just dying the armor with the white dye in a crafting table, but it's overall annoying to do every single time.

(This actually isn't the first time it happened by the way, i remember a couple of years ago with another Flans Mod version).

Image

@GoldSloth
Copy link
Collaborator

Hi @Bu0ngiorno, thanks for reporting this - this was actually fixed a couple weeks ago in the latest commit, it was caused by us using the cloth armour type (same as leather) for Flans armour, which can be recoloured. CustomNPCs sees that it's cloth but gets a dye value indicating that it should be brown, and renders that. We've switched back to using a custom armour type that can't be dyed, but we can still set the enchantability value which is why we used cloth/leather in the first place.

5a54812

I'll upload a test build that you can try, please let me know if this doesn't fix it for you.

@Bu0ngiorno
Copy link
Author

@GoldSloth alrighty then, thank you so much for replying to my post and for fixing this annoying issue!

And yeah, i will try that build out when i am able to, so if i see any more bugs, i'll report them here on the GitHub. :)

@GoldSloth
Copy link
Collaborator

Here's the test build:

Flan's Mod Ultimate Stability Edition-1.6001.zip

@Bu0ngiorno
Copy link
Author

@GoldSloth Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants