From fb8874a5fa73d537d2798b7f9be4234aa8294d03 Mon Sep 17 00:00:00 2001
From: Simon Hornby <liquidwicked64@gmail.com>
Date: Wed, 9 Oct 2024 15:17:44 +0200
Subject: [PATCH] fix: remove bucket creation in s3 persister

---
 server/src/persistence/s3.rs | 28 ----------------------------
 1 file changed, 28 deletions(-)

diff --git a/server/src/persistence/s3.rs b/server/src/persistence/s3.rs
index a7513188..28d621a9 100644
--- a/server/src/persistence/s3.rs
+++ b/server/src/persistence/s3.rs
@@ -53,32 +53,6 @@ impl From<SdkError<PutObjectError>> for EdgeError {
     }
 }
 
-impl S3Persister {
-    async fn create_bucket_if_not_exists(&self) -> EdgeResult<()> {
-        match self
-            .client
-            .create_bucket()
-            .bucket(&self.bucket)
-            .send()
-            .await
-        {
-            Ok(_) => Ok(()),
-            Err(err) => {
-                if err.to_string().contains("BucketAlreadyOwnedByYou")
-                    || err.to_string().contains("BucketAlreadyExists")
-                {
-                    Ok(())
-                } else {
-                    Err(EdgeError::PersistenceError(format!(
-                        "Failed to create bucket: {}",
-                        err
-                    )))
-                }
-            }
-        }
-    }
-}
-
 #[async_trait]
 impl EdgePersistence for S3Persister {
     async fn load_tokens(&self) -> EdgeResult<Vec<EdgeToken>> {
@@ -96,7 +70,6 @@ impl EdgePersistence for S3Persister {
     }
 
     async fn save_tokens(&self, tokens: Vec<EdgeToken>) -> EdgeResult<()> {
-        self.create_bucket_if_not_exists().await?;
         let body_data = serde_json::to_vec(&tokens)
             .map_err(|_| EdgeError::PersistenceError("Failed to serialize tokens".to_string()))
             .map(SdkBody::from)?;
@@ -144,7 +117,6 @@ impl EdgePersistence for S3Persister {
     }
 
     async fn save_features(&self, features: Vec<(String, ClientFeatures)>) -> EdgeResult<()> {
-        self.create_bucket_if_not_exists().await?;
         let body_data = serde_json::to_vec(&features)
             .map_err(|_| EdgeError::PersistenceError("Failed to serialize features".to_string()))?;
         let byte_stream = ByteStream::new(SdkBody::from(body_data));