From 29fe68aacae0741b7d4ae8602c7ed2c08bfa109b Mon Sep 17 00:00:00 2001
From: kwasniew <kwasniewski.mateusz@gmail.com>
Date: Thu, 30 Jan 2025 15:33:26 +0100
Subject: [PATCH] feat: drop x- header prefix

---
 src/lib/metrics.ts                          | 6 +++---
 src/lib/middleware/response-time-metrics.ts | 1 +
 2 files changed, 4 insertions(+), 3 deletions(-)

diff --git a/src/lib/metrics.ts b/src/lib/metrics.ts
index 3fb0969a6914..558a81a89fef 100644
--- a/src/lib/metrics.ts
+++ b/src/lib/metrics.ts
@@ -271,7 +271,7 @@ export function registerPrometheusMetrics(
 
     dbMetrics.registerGaugeDbMetric({
         name: 'unique_sdk_connections_total',
-        help: 'The number of unique SDK connections for the full previous hour across all instances. Available only for SDKs reporting `unleash-x-connection-id`',
+        help: 'The number of unique SDK connections for the full previous hour across all instances. Available only for SDKs reporting `unleash-connection-id`',
         query: () => {
             if (flagResolver.isEnabled('uniqueSdkTracking')) {
                 return stores.uniqueConnectionReadModel.getStats();
@@ -283,7 +283,7 @@ export function registerPrometheusMetrics(
 
     dbMetrics.registerGaugeDbMetric({
         name: 'unique_backend_sdk_connections_total',
-        help: 'The number of unique backend SDK connections for the full previous hour across all instances. Available only for SDKs reporting `unleash-x-connection-id`',
+        help: 'The number of unique backend SDK connections for the full previous hour across all instances. Available only for SDKs reporting `unleash-connection-id`',
         query: () => {
             if (flagResolver.isEnabled('uniqueSdkTracking')) {
                 return stores.uniqueConnectionReadModel.getStats();
@@ -295,7 +295,7 @@ export function registerPrometheusMetrics(
 
     dbMetrics.registerGaugeDbMetric({
         name: 'unique_frontend_sdk_connections_total',
-        help: 'The number of unique frontend SDK connections for the full previous hour across all instances. Available only for SDKs reporting `unleash-x-connection-id`',
+        help: 'The number of unique frontend SDK connections for the full previous hour across all instances. Available only for SDKs reporting `unleash-connection-id`',
         query: () => {
             if (flagResolver.isEnabled('uniqueSdkTracking')) {
                 return stores.uniqueConnectionReadModel.getStats();
diff --git a/src/lib/middleware/response-time-metrics.ts b/src/lib/middleware/response-time-metrics.ts
index 05a909d573df..02b6080412c9 100644
--- a/src/lib/middleware/response-time-metrics.ts
+++ b/src/lib/middleware/response-time-metrics.ts
@@ -68,6 +68,7 @@ export function responseTimeMetrics(
 
         if (flagResolver.isEnabled('uniqueSdkTracking')) {
             const connectionId =
+                req.headers['unleash-connection-id'] ||
                 req.headers['x-unleash-connection-id'] ||
                 req.headers['unleash-instanceid'];
             if (req.originalUrl.includes('/api/client') && connectionId) {