Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Echo commit hash used for cloning IOR and MDREAL #29

Open
vnobody opened this issue Aug 9, 2018 · 2 comments
Open

Echo commit hash used for cloning IOR and MDREAL #29

vnobody opened this issue Aug 9, 2018 · 2 comments

Comments

@vnobody
Copy link

vnobody commented Aug 9, 2018

Hello.
Probably it would be good to echo commit hashes while cloning IOR and MDREAL repositories in prepare.sh? Currently it clones the repos and checks out the latest commits by default. Reason for this change might be, when testing multiple systems in different days/months and installing fresh version, there might be a situation, that results are with big difference and users might wonder why this happened. In that case, the reason will be, that different versions of IOR or MDREAL were used.

@adilger
Copy link
Collaborator

adilger commented Aug 9, 2018

It also makes sense to add a git tag to the repository before when IO-500 list is published at ISC and SC. While this does not guarantee which version of the script or tools was run for a given benchmark result (the actual commit hashes for IOR and io-500-dev should be included in the result submission) it does give an approximate state of affairs at each publication date for future reference.

At some point, when the IO-500 scripts have stabilized more, and there are more participants submitting results, it might make sense to mandate a specific version of the scripts and IOR for a given list, so that everyone has a level playing field.

@JulianKunkel
Copy link
Contributor

JulianKunkel commented Aug 10, 2018 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants