-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[New Plugin]: binaryninja-ollama #274
Comments
read me was overwritten by release script, reposting |
No worries, I have some other feedback i'm working on. |
Here's my comments so far: Thanks for the submission. Should https://github.com/ahaggard2013/binaryninja-ollama/blob/main/ui.py#L28C43-L28C57 be updated to use 127.0.0.1 instead? Also, please remove PySide6 in the requirements.txt as that is automatically provided by Binary Ninja if you first Alternatively, you could replace the UI code with interaction API calls so you don't have to write pyside at all. Not important suggestion: |
thanks, fixed the ip/requirements, porting to interaction calls and type hinting will take a a bit more effort, but will look into it! |
Reopening this - please make a release with the requirements fixes |
TL;DR your latest code has the change to requirements, but not the latest release actually cut. This actually caused a user who installed the plugin to have all UI plugins break unfortunately so we've removed it from the plugin manager until it's resolved. |
whoops! I'm new to configuring releases and didn't release they weren't aligned, should be fixed now. |
Thanks -- added back. Also, have you tried https://github.com/mrphrazer/reverser_ai ? I don't think I mentioned it before but it also uses an ollama model. Might be worth consolidating/merging any shared features, though Tim's plugin is GPLv2 so that could be an issue. |
I didn't see that plugin! That's awesome, very similar. I originally only saw the openai one which sparked the effort. I will have to give it a try later, looks like it has some cool additional features. Agreed on consolidation, I probably would have just worked off his version if I saw it first. |
Plugin Description
Plugin to rename functions and variables with a locally hosted ollama server. Can use any of the openly available models such as llama3 and gemma2.
Plugin Repository URL
Repo URL: https://github.com/ahaggard2013/binaryninja-ollama
Real Release
The text was updated successfully, but these errors were encountered: