Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

loggingparameters #24

Open
5 tasks done
VincyaneBadouard opened this issue Jul 19, 2021 · 3 comments
Open
5 tasks done

loggingparameters #24

VincyaneBadouard opened this issue Jul 19, 2021 · 3 comments
Labels

Comments

@VincyaneBadouard
Copy link
Owner

VincyaneBadouard commented Jul 19, 2021

  • code
  • test
  • document (V0)
  • Sylvain's check (code)
  • Geraldine check (doc)
@sylvainschmitt
Copy link
Collaborator

sylvainschmitt commented Jul 20, 2021

Review of the code

@VincyaneBadouard , here is my review of the code. Beware, you can totally disagree with me and it's fine! Also tell me if you like the revision this way or if you would prefer a pull request?

Help

  • l. 1 Other parameters is not very specific, something more descriptive would be better, advanced parameters?
  • 80 character lines (CTRL+MAJ+/)
  • l. 31 meanσ > mean σ
  • l. 41 consider adding a new line between the example in roxygen and the name of the function

Code

  • try avoiding comments in french
  • l. 126 use Allometry instead of Models

Test

I don't see the test file?

sylvainschmitt added a commit that referenced this issue Jul 20, 2021
@sylvainschmitt
Copy link
Collaborator

I'm unchecking the review of the code as you also lack a test of user inputs (see #23 )

@sylvainschmitt
Copy link
Collaborator

Ok for me now! Kudos for the input checks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants