Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

getgeometry #37

Open
5 tasks done
VincyaneBadouard opened this issue Aug 4, 2021 · 2 comments
Open
5 tasks done

getgeometry #37

VincyaneBadouard opened this issue Aug 4, 2021 · 2 comments
Labels

Comments

@VincyaneBadouard
Copy link
Owner

VincyaneBadouard commented Aug 4, 2021

  • code
  • test
  • document (V0)
  • Sylvain's check (code)
  • Geraldine check (doc)
@sylvainschmitt
Copy link
Collaborator

sylvainschmitt commented Aug 4, 2021

  • the name of the function is in snake_case and not in lowercase
  • the example doesn't work (see below)
  • Why (type: "environment") inthe help? What does that mean?
  • 0.2s a bit long but okay for the test
> Rslt <- get_geometry(inventory, LocPts)
Error in st_as_sf(., wkt = col_name) : 
  impossible de trouver la fonction "st_as_sf"
Called from: inventory %>% dplyr::filter(!is.na({
    {
        var
    }
})) %>% st_as_sf(wkt = col_name)

@VincyaneBadouard VincyaneBadouard changed the title get_geometry getgeometry Aug 6, 2021
VincyaneBadouard pushed a commit that referenced this issue Aug 6, 2021
VincyaneBadouard pushed a commit that referenced this issue Aug 6, 2021
VincyaneBadouard pushed a commit that referenced this issue Aug 6, 2021
@sylvainschmitt
Copy link
Collaborator

Good work

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants