Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Introduce privacy policy page. #79

Closed
wants to merge 1 commit into from
Closed

Introduce privacy policy page. #79

wants to merge 1 commit into from

Conversation

AdarshThakare
Copy link
Contributor

@AdarshThakare AdarshThakare commented Oct 10, 2024 •
edited by Vishwajith-Shettigar
Loading

Description

Fixes #83
I have tried to successfully create the UI for privacy screen using frame-layout and constraint-layout in android studio.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented on my code, particularly in hard-to-understand areas

Screenshot

Screenshot 2024-10-10 at 7 53 43 PM

Screenshots / Screen Recordings

Screenshot 2024-10-10 at 8 00 19 PM

Note: Only ask for review when you complete all above.

kindly review and convey the corrections needed for improvement.

@Vishwajith-Shettigar
Copy link
Owner

@AdarshThakare the issue is about changing layout to constraint layout, but you seems like created privacy policy page.

@Vishwajith-Shettigar
Copy link
Owner

Vishwajith-Shettigar commented Oct 11, 2024 •
edited
Loading

I will suggest you to create new privacy policy option in profile screen. And create new privacy policy screen for policy texts.

@Vishwajith-Shettigar Vishwajith-Shettigar changed the title privacy Screen UI created Introduce privacy policy page. Oct 11, 2024
@Vishwajith-Shettigar
Copy link
Owner

Issue for this PR #83

@AdarshThakare
Copy link
Contributor Author

I will suggest you to create new privacy policy option in profile screen. And create new privacy policy screen for policy texts.

@AdarshThakare AdarshThakare reopened this Oct 11, 2024
@AdarshThakare
Copy link
Contributor Author

Got it. But i think it would be more appropriate to add the privacy policy screen as a item in privacy tab of profile screen.
Would that be ok?

@Vishwajith-Shettigar
Copy link
Owner

Got it. But i think it would be more appropriate to add the privacy policy screen as a item in privacy tab of profile screen. Would that be ok?

Add an option "Privacy Policy" below "Account". We will refactor "Privacy" into "Settings" in future.
image

@AdarshThakare
Copy link
Contributor Author

Ok on it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Feature] Introduce privacy policy page.
2 participants
@AdarshThakare @Vishwajith-Shettigar