Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggestion: Change the build command from pipenv install --dev --system --deploy to pipenv install --categories="dev-packages packages" --system --deploy #7

Open
unesmu opened this issue Jan 26, 2023 · 0 comments

Comments

@unesmu
Copy link

unesmu commented Jan 26, 2023

Currently in the Install dependencies step of this GitHub action the command pipenv install --dev --system --deploy is used.

This will by default install all package categories in the Pipfile, which means it will install package categories other than the [packages] and the [dev-packages] one.

One could have some build categories in the Pipfile such as [packages-mac] and [dev-packages-mac] that are only used for development.

In this scenario, those build categories are not intended to be built in the GitHub action as it is a Linux machine and the categories include macos dependencies.

What I suggest is to use the command pipenv install --categories="dev-packages packages" --system --deploy instead, which will only install the dev-packages and packages categories from the pipfile.

More about package categories here

Potential issues with my suggestion:
In case someone wanted to organize their packages in the Pipfile differently, and have different categories other than packages and dev-packages , but still wants to install them all when building their environment.

PR #8 implements this suggestion.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant