Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Policy container #6

Open
annevk opened this issue Jun 3, 2022 · 1 comment
Open

Policy container #6

annevk opened this issue Jun 3, 2022 · 1 comment
Labels
enhancement New feature or request

Comments

@annevk
Copy link

annevk commented Jun 3, 2022

Should the anonymous bit be stored on a policy container? It seems like it is meant to inherit into all the relevant places.
@ArthurSonzogni
Copy link
Collaborator

I think it make sense.

I was modeled similarly to sandbox. Chrome is moving the document's sandbox into the document's PolicyContainer.
It makes sense this applies to the anonymous bit as well.

Actually, this came up during a code review:
https://chromium-review.googlesource.com/c/chromium/src/+/3634527/18/third_party/blink/renderer/core/loader/frame_loader.cc
and a bug was created for it:
https://bugs.chromium.org/p/chromium/issues/detail?id=1325733

@ArthurSonzogni ArthurSonzogni added the enhancement New feature or request label Jun 3, 2022
aarongable pushed a commit to chromium/chromium that referenced this issue Jun 16, 2022
@ArthurSonzogni
AnonymousIframe: Move the windows's bit into PolicyContainer.
e41678a 
This was suggested during code review here:
https://chromium-review.googlesource.com/c/chromium/src/+/3634527/18/third_party/blink/renderer/core/loader/frame_loader.cc

And also suggested by annevk@ (Mozilla) here:
WICG/anonymous-iframe#6

Fixed: 1325733
Bug: 1325733
Change-Id: I21bad14af5b84f9fc31ab62f2a4d1ba6cdd91f2d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3695248
Reviewed-by: Daniel Cheng <[email protected]>
Reviewed-by: Antonio Sartori <[email protected]>
Commit-Queue: Arthur Sonzogni <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1014925}
@ArthurSonzogni ArthurSonzogni mentioned this issue Jun 29, 2022
Open
mjfroman pushed a commit to mjfroman/moz-libwebrtc-third-party that referenced this issue Oct 14, 2022
@ArthurSonzogni @copybara-github
AnonymousIframe: Move the windows's bit into PolicyContainer.
1a27fe0 
This was suggested during code review here:
https://chromium-review.googlesource.com/c/chromium/src/+/3634527/18/third_party/blink/renderer/core/loader/frame_loader.cc

And also suggested by annevk@ (Mozilla) here:
WICG/anonymous-iframe#6

Fixed: 1325733
Bug: 1325733
Change-Id: I21bad14af5b84f9fc31ab62f2a4d1ba6cdd91f2d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3695248
Reviewed-by: Daniel Cheng <[email protected]>
Reviewed-by: Antonio Sartori <[email protected]>
Commit-Queue: Arthur Sonzogni <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1014925}
NOKEYCHECK=True
GitOrigin-RevId: e41678a49a5eed60e29b0a313ad4f495ecd4d0c9
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@annevk @ArthurSonzogni