Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bulk label update packet (0x1d) restructure (proposal) #44

Open
mworzala opened this issue Oct 19, 2020 · 0 comments
Open

Bulk label update packet (0x1d) restructure (proposal) #44

mworzala opened this issue Oct 19, 2020 · 0 comments

Comments

@mworzala
Copy link
Contributor

There is an established "String" type used in other packets (4 bytes to represent the length, and then the variable number of characters afterwards) such as Console Data (0x11) and New Value Index (0x1F).

As it stands, bulk value update contains a list of "elements" each specifying the offset and length of their associated string in a single long concatenated string data segment at the end of the packet.

It seems like it would be more consistent to use the common format inside this list of indices. And it would make the packet smaller! Something like the following:

Packet ID Field Name Field Type Notes
0x1d Number of labels (n) Unsigned Int
Once for each n Index Unsigned Int The label index to update.
String Length Unsigned Int
String Data Bytes Of length "String Length"

Note: This would make it so that each list element is not a set length, but I don't see any major problems with this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant