Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keeps opening google wiki tab #13

Closed
AndrejusAnto opened this issue Jan 28, 2025 · 8 comments
Closed

Keeps opening google wiki tab #13

AndrejusAnto opened this issue Jan 28, 2025 · 8 comments
Assignees
Labels
bug Something isn't working

Comments

@AndrejusAnto
Copy link

Hi, respect for extension, I was thinning about similar extension, but using Chatgpt and python :D because I don't have experience (and don't want) with JavaScript. Bug is that it keeps opening tab of google wiki page. Windows 11 and Brave, not sure what info to provide.

@SalimOfShadow
Copy link

Can you please check if #7
fixes the issue or not?
Thank you very much.

@AndrejusAnto
Copy link
Author

No and getting "'background.scripts' requires manifest version of 2 or lower." in extension tab via Errors of extention.

@AndrejusAnto
Copy link
Author

It seems after some time also open some random wiki like Youtube, Meta.

@SalimOfShadow
Copy link

Mmmm this is weird, can you please record a video of this problem occurring or provide us with a reproducible example?

@WayneKeenan
Copy link
Owner

@AndrejusAnto I currently test with Brave 1.74.50 on macOS, please let me know the version of Brave are you on, thanks.

@WayneKeenan WayneKeenan self-assigned this Jan 29, 2025
@WayneKeenan WayneKeenan added the bug Something isn't working label Jan 29, 2025
@jaredcat
Copy link

jaredcat commented Jan 29, 2025

Edit: comment about manifest version error moved to its own issue: #33

@AndrejusAnto
Copy link
Author

Sorry, I am stupid, to clarify I have opened youtube and other tabs, but google, youtube wiki pages even I am not in specific youtube tab, see the gif.

Image

@WayneKeenan
Copy link
Owner

Due to pain in managing the tab state and it was just a quick win for initial POC I've decided to drop opening background tabs and instead will use toolbar notification and eventually an in-page toast.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants