Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Calibration problem #37

Open
cdupont opened this issue Nov 21, 2019 · 2 comments
Open

Calibration problem #37

cdupont opened this issue Nov 21, 2019 · 2 comments
Assignees
Labels
enhancement New feature or request

Comments

@cdupont
Copy link
Collaborator

cdupont commented Nov 21, 2019

Currently, when a calibration is present in the "sensor" datastructure, this calibration will be used to calculate the values output by the API (e.g. in devices/XX/sensors/YY/values).
This will cause problems because the "value/values" fields of a sensor changes meaning.
For instance the synchronisation module in the gateways will think this is the raw value, while this might be the calibrated value.

@cdupont cdupont added the enhancement New feature or request label Nov 21, 2019
@cdupont cdupont self-assigned this Nov 21, 2019
@cdupont
Copy link
Collaborator Author

cdupont commented Nov 21, 2019

Proposed change:

  • add value_calibrated field in the sensor datastructure. This read-only, optional field will contain the calibrated values, when there is a calibration.
  • The existing value field will contain the raw value (instead of raw/calibrated) in read-write mode.

Having two fields allows to avoid confusion. There should be no changes on the gateway side. On the dashboard side, I think it is better to display the calibrated value, when it is available.

@cdupont
Copy link
Collaborator Author

cdupont commented Nov 21, 2019

@j-forster

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant