From 70ac02aa1ca260707a43309fa5a5e752d0a30f59 Mon Sep 17 00:00:00 2001
From: holmbergius <holmbergius@gmail.com>
Date: Thu, 7 Nov 2024 10:23:33 -0800
Subject: [PATCH 1/3] Remove opening, unneeded HTML opening comment

---
 src/main/webapp/iaResults.jsp | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/main/webapp/iaResults.jsp b/src/main/webapp/iaResults.jsp
index 3808f03356..241d546595 100755
--- a/src/main/webapp/iaResults.jsp
+++ b/src/main/webapp/iaResults.jsp
@@ -1,4 +1,4 @@
-<!-- <%@ page contentType="text/html; charset=iso-8859-1" language="java"
+<%@ page contentType="text/html; charset=iso-8859-1" language="java"
          import="org.ecocean.servlet.ServletUtilities,javax.servlet.http.HttpUtils,
 org.json.JSONObject, org.json.JSONArray,
 org.ecocean.media.*,

From fc0a9c49ae13185fc03512f1db589e76314cb761 Mon Sep 17 00:00:00 2001
From: TanyaStere42 <tstere@wildme.org>
Date: Thu, 7 Nov 2024 12:38:46 -0800
Subject: [PATCH 2/3] project only displays when projects are available

---
 src/main/webapp/submit.jsp | 30 +++++++++++++++---------------
 1 file changed, 15 insertions(+), 15 deletions(-)

diff --git a/src/main/webapp/submit.jsp b/src/main/webapp/submit.jsp
index f9cba48c8a..e527140777 100755
--- a/src/main/webapp/submit.jsp
+++ b/src/main/webapp/submit.jsp
@@ -124,26 +124,25 @@ function populateProjectNameDropdown(options, values, selectedOption, isVisible,
 		defaultSelectItemId = null;
 		loggedOutDefaultDesired = false;
 	}
-	// if(options.length<1){
-	// 	isVisible=false;
-	// }
+	if(options.length<1){
+	 	isVisible=false;
+	}
 		let projectNameHtml = '';
-		projectNameHtml += '<div class="col-xs-6 col-md-4">';
-		if(loggedOutDefaultDesired){
+
+		if(isVisible){
+			projectNameHtml += '<div class="col-xs-6 col-md-4"><label class="control-label"><%=props.getProperty("projectMultiSelectLabel") %></label></div><div class="col-xs-6 col-lg-8"><select name="proj-id-dropdown" id="proj-id-dropdown" class="form-control" multiple="multiple">';
+		}
+
+		//options
+    if(loggedOutDefaultDesired){
 			projectNameHtml += '<input type="hidden" name="defaultProject" id="defaultProject" value="' + getDefaultSelectedProjectId() + '" />';
 			// console.log("hidden default project selected with name: " + getDefaultSelectedProjectId());
 		}
-		if(isVisible){
-			projectNameHtml += '<label class="control-label "><%=props.getProperty("projectMultiSelectLabel") %></label>';
-			projectNameHtml += '<select name="proj-id-dropdown" id="proj-id-dropdown" class="form-control" multiple="multiple">';
-		}else{
-			projectNameHtml += '<select style="display: none;" name="proj-id-dropdown" id="proj-id-dropdown" class="form-control" multiple="multiple">';
-		}
-		projectNameHtml += '<option value=""></option>';
-		if(defaultSelectItem){
+    if(defaultSelectItem){
 			projectNameHtml += '<option value="' + defaultSelectItemId + '" selected>'+ defaultSelectItem +'</option>';
 			options = options.remove(defaultSelectItem);
 		}
+    projectNameHtml += '<option value=""></option>';
 		for(let i=0; i<options.length; i++){
 			if(options[i] === selectedOption){
 				projectNameHtml += '<option value="'+ values[i] +'" selected>'+ options[i] +'</option>';
@@ -151,7 +150,8 @@ function populateProjectNameDropdown(options, values, selectedOption, isVisible,
 				projectNameHtml += '<option value="'+ values[i] + '">'+ options[i] +'</option>';
 			}
 		}
-		projectNameHtml += '</div>';
+    
+		projectNameHtml += '</div></div>';
 		$("#proj-id-dropdown-container").empty();
 		$("#proj-id-dropdown-container").append(projectNameHtml);
 }
@@ -988,7 +988,7 @@ if(CommonConfiguration.showProperty("maximumElevationInMeters",context)){
 
   <fieldset>
 
-		<div class="form-group form-inline" id="proj-id-dropdown-container">
+		<div class="form-group" id="proj-id-dropdown-container">
 		</div>
 
     <div class="form-group">

From ca9d034465b8dab61d17ffb7d8f3bb2f62870952 Mon Sep 17 00:00:00 2001
From: TanyaStere42 <tstere@wildme.org>
Date: Thu, 7 Nov 2024 12:59:53 -0800
Subject: [PATCH 3/3] removed default project by organization

---
 .../tomcat/commonConfiguration.properties     |  6 ---
 .../tomcat/commonConfiguration.properties     |  6 ---
 .../java/org/ecocean/CommonConfiguration.java | 16 -------
 .../bundles/commonConfiguration.properties    |  6 ---
 src/main/webapp/submit.jsp                    | 42 ++++---------------
 5 files changed, 7 insertions(+), 69 deletions(-)

diff --git a/devops/deploy/.dockerfiles/tomcat/commonConfiguration.properties b/devops/deploy/.dockerfiles/tomcat/commonConfiguration.properties
index 1a336a9487..5a4037b5d5 100644
--- a/devops/deploy/.dockerfiles/tomcat/commonConfiguration.properties
+++ b/devops/deploy/.dockerfiles/tomcat/commonConfiguration.properties
@@ -25,12 +25,6 @@
 #file system folder in which marked individual data will be stored (e.g. data files)
 #markedIndividualDirectoryLocation=individuals
 
-# default behaviors for Project object
-loggedOutDefaultDesired = true
-defaultProjectOrganizationParameter = IndoCet
-defaultProjName = Indocet Opportunistic Sightings
-defaultProjId = IndoCetOppS-
-
 #file system folder in which adoption data will be stored (e.g. photos)
 #adoptionLocation=adoptions
 
diff --git a/devops/development/.dockerfiles/tomcat/commonConfiguration.properties b/devops/development/.dockerfiles/tomcat/commonConfiguration.properties
index 4a37384b95..6e6e1a13f8 100644
--- a/devops/development/.dockerfiles/tomcat/commonConfiguration.properties
+++ b/devops/development/.dockerfiles/tomcat/commonConfiguration.properties
@@ -25,12 +25,6 @@
 #file system folder in which marked individual data will be stored (e.g. data files)
 #markedIndividualDirectoryLocation=individuals
 
-# default behaviors for Project object
-loggedOutDefaultDesired = true
-defaultProjectOrganizationParameter = IndoCet
-defaultProjName = Indocet Opportunistic Sightings
-defaultProjId = IndoCetOppS-
-
 #file system folder in which adoption data will be stored (e.g. photos)
 #adoptionLocation=adoptions
 
diff --git a/src/main/java/org/ecocean/CommonConfiguration.java b/src/main/java/org/ecocean/CommonConfiguration.java
index c1fb456956..d06115dcdd 100644
--- a/src/main/java/org/ecocean/CommonConfiguration.java
+++ b/src/main/java/org/ecocean/CommonConfiguration.java
@@ -385,22 +385,6 @@ public static String getNewSubmissionEmail(String context) {
         return getProperty("newSubmissionEmail", context).trim();
     }
 
-    public static String getDefaultSelectedProject(String context) {
-        return getProperty("defaultProjName", context).trim();
-    }
-
-    public static String getDefaultProjectOrganizationParameter(String context) {
-        return getProperty("defaultProjectOrganizationParameter", context).trim();
-    }
-
-    public static String getDefaultSelectedProjectId(String context) {
-        return getProperty("defaultProjId", context).trim();
-    }
-
-    public static boolean getLoggedOutDefaultDesired(String context) {
-        return parseBoolean(getProperty("loggedOutDefaultDesired", context), false);
-    }
-
     public static String getR(String context) {
         return getProperty("R", context).trim();
     }
diff --git a/src/main/resources/bundles/commonConfiguration.properties b/src/main/resources/bundles/commonConfiguration.properties
index 3ac1285131..3077133084 100755
--- a/src/main/resources/bundles/commonConfiguration.properties
+++ b/src/main/resources/bundles/commonConfiguration.properties
@@ -6,12 +6,6 @@
 #file system folder in which marked individual data will be stored (e.g. data files)
 #markedIndividualDirectoryLocation=individuals
 
-# default behaviors for Project object
-loggedOutDefaultDesired = true
-defaultProjectOrganizationParameter = IndoCet
-defaultProjName = Indocet Opportunistic Sightings
-defaultProjId = IndoCetOppS-
-
 dataDirectoryName = wildbook_data_dir
 
 #URL to the graphic to be displayed at the top of every page through header.jsp
diff --git a/src/main/webapp/submit.jsp b/src/main/webapp/submit.jsp
index e527140777..6f0c63c168 100755
--- a/src/main/webapp/submit.jsp
+++ b/src/main/webapp/submit.jsp
@@ -96,7 +96,7 @@ $(document).ready( function() {
    $('#locationID').select2({width: '100%', height:'50px'});
    $('#country').select2({width: '100%', height:'50px'});
 
-	populateProjectNameDropdown([],[],"", false, getDefaultSelectedProject(), getDefaultSelectedProjectId(), getLoggedOutDefaultDesired());
+	populateProjectNameDropdown([],[],"", false);
 	<%
 	if(user != null){
 		%>
@@ -115,15 +115,11 @@ $(document).ready( function() {
 	%>
 });
 
-function populateProjectNameDropdown(options, values, selectedOption, isVisible, defaultSelectItem, defaultSelectItemId, loggedOutDefaultDesired){
-	let useCustomStyle = '<%= ServletUtilities.useCustomStyle(request,CommonConfiguration.getDefaultProjectOrganizationParameter(context)) %>' == "true"?true: false;
-	if(useCustomStyle){
-		//do nothing unusual
-	}else{
-		defaultSelectItem = null;
-		defaultSelectItemId = null;
-		loggedOutDefaultDesired = false;
-	}
+function populateProjectNameDropdown(options, values, selectedOption, isVisible, defaultSelectItem, defaultSelectItemId){
+
+	defaultSelectItem = null;
+	defaultSelectItemId = null;
+	
 	if(options.length<1){
 	 	isVisible=false;
 	}
@@ -134,10 +130,6 @@ function populateProjectNameDropdown(options, values, selectedOption, isVisible,
 		}
 
 		//options
-    if(loggedOutDefaultDesired){
-			projectNameHtml += '<input type="hidden" name="defaultProject" id="defaultProject" value="' + getDefaultSelectedProjectId() + '" />';
-			// console.log("hidden default project selected with name: " + getDefaultSelectedProjectId());
-		}
     if(defaultSelectItem){
 			projectNameHtml += '<option value="' + defaultSelectItemId + '" selected>'+ defaultSelectItem +'</option>';
 			options = options.remove(defaultSelectItem);
@@ -167,26 +159,6 @@ Array.prototype.remove = function() {
     return this;
 };
 
-function getDefaultSelectedProject(){
-	let defaultProject = '<%= CommonConfiguration.getDefaultSelectedProject(context) %>';
-	return defaultProject;
-}
-
-function getDefaultProjectOrganizationParameter(){
-	let defaultProjectOrganizationParameter = '<%= CommonConfiguration.getDefaultProjectOrganizationParameter(context) %>';
-	return defaultProjectOrganizationParameter;
-}
-
-function getDefaultSelectedProjectId(){
-	let defaultProjectId = '<%= CommonConfiguration.getDefaultSelectedProjectId(context) %>';
-	return defaultProjectId;
-}
-
-function getLoggedOutDefaultDesired(){
-	let loggedOutDefaultDesired = '<%= CommonConfiguration.getLoggedOutDefaultDesired(context) %>';
-	return loggedOutDefaultDesired;
-}
-
 function doAjaxForProject(requestJSON,userId){
 	$.ajax({
 			url: wildbookGlobals.baseUrl + '../ProjectGet',
@@ -200,7 +172,7 @@ function doAjaxForProject(requestJSON,userId){
 				if(projectNameResults){
 					projNameOptions = projectNameResults.map(entry =>{return entry.researchProjectName});
 					projNameIds = projectNameResults.map(entry =>{return entry.projectIdPrefix});
-					populateProjectNameDropdown(projNameOptions,projNameIds,"", true, getDefaultSelectedProject(), getDefaultSelectedProjectId(), getLoggedOutDefaultDesired());
+					populateProjectNameDropdown(projNameOptions,projNameIds,"", true);
 				}
 			},
 			error: function(x,y,z) {