Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

annoying warning when stopping a non running tween #39

Open
polco opened this issue Nov 24, 2015 · 3 comments
Open

annoying warning when stopping a non running tween #39

polco opened this issue Nov 24, 2015 · 3 comments

Comments

@polco
Copy link

polco commented Nov 24, 2015

Calling silent(true) on the tweener doesn't remove the warning when calling stop on a tween that is not running.
'[Playable.stop] Cannot stop a playable that is not running'

@bchevalier
Copy link
Contributor

This should be fixed, let me know if not.

@polco
Copy link
Author

polco commented Feb 3, 2016

so from what I tried, if i use the the method getDefaultTweener and try calling silent(true) it doesn't turn off the warnings. If I created my own Tweener new TINA.Timer(1000), there is no more warning with or without calling silent(true). Maybe you should document this API on your readme by the way !
Anyway, i finally have a clean console log, thanks 💃

@bchevalier
Copy link
Contributor

Thanks for the details. Actually I tried to reproduce the issue you describe but it seems to work properly. The code I tested is the following:

    var defaultTweener = TINA.getDefaultTweener();
    defaultTweener.silent(true);

    var myArray = [0, 1, 2];
    var myTween = TINA.Tween(myArray)
        .to([0, 2, 4], 300)
        .start();

    myTween.stop();
    myTween.stop();

No warning popped up.

Could you share the code for which you have the issue?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants