Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepare PL 3.9 Release #1852

Closed
5 tasks done
felixarntz opened this issue Feb 10, 2025 · 7 comments · Fixed by #1870
Closed
5 tasks done

Prepare PL 3.9 Release #1852

felixarntz opened this issue Feb 10, 2025 · 7 comments · Fixed by #1870
Assignees
Labels
[Plugin] Performance Lab Issue relates to work in the Performance Lab Plugin only

Comments

@felixarntz
Copy link
Member

felixarntz commented Feb 10, 2025

This issue is to track preparation of the upcoming 3.9.0 release up until publishing, which is due February 13, 2025.

  • Create release/3.9.0 branch closer to the release date
  • Finalize scope and punt unfinished pull requests to following release (Monday, February 10, 2025)
  • Bump versions in milestones according to the scope (Monday, February 10, 2025)
  • Smoke test (Tuesday, February 11, 2025)
  • Prepare the release (Thursday, February 13, 2025)

Note: The release would normally happen on Monday February 17, but due to a US holiday and following WordCamp Asia the release is moved a few days ahead.

@felixarntz felixarntz added the [Plugin] Performance Lab Issue relates to work in the Performance Lab Plugin only label Feb 10, 2025
@felixarntz felixarntz added this to the performance-lab 3.9.0 milestone Feb 10, 2025
@github-project-automation github-project-automation bot moved this to Not Started/Backlog 📆 in WP Performance 2024 Feb 10, 2025
@felixarntz felixarntz moved this from Not Started/Backlog 📆 to To Do 🔧 in WP Performance 2024 Feb 10, 2025
@felixarntz
Copy link
Member Author

Note: This releases marks an important milestone, with both Image Prioritizer and Embed Optimizer graduating to non-experimental status, with their versions being bumped to 1.0.0-beta, similar to Optimization Detective last month.

For Embed Optimizer, this means we will still do a release even though it technically contains no changes.

Other than the plugins from the Optimization Detective family, only Performance Lab will need to be released in a new version, due to the change of the other plugins' experimental status.

@westonruter
Copy link
Member

Release branch created: https://github.com/WordPress/performance/tree/release/3.9.0

Scope set to these 4 plugins, with Embed Optimizer just being a version bump:

Image

@westonruter
Copy link
Member

PR with version bumps: #1862

@westonruter westonruter mentioned this issue Feb 11, 2025
3 tasks
@westonruter westonruter moved this from To Do 🔧 to Code Review 👀 in WP Performance 2024 Feb 11, 2025
@westonruter
Copy link
Member

westonruter commented Feb 12, 2025

Testing the builds at https://complicated-lyrebird-c797ca.instawp.xyz/

✅ In the new version of Performance Lab, I see Embed Optimizer and Image Prioritizer are no longer shown as experimental:

Image

✅ For Embed Optimizer, I see that a Tweet embed is getting the new CSS range syntax for setting the min-height for a tweet: https://complicated-lyrebird-c797ca.instawp.xyz/tweet/

<style>
@media (width <= 480px) { #embed-optimizer-4b1647ded78fdafc89edd99a29b10f78 { min-height: 693px; } }
@media (480px < width <= 600px) { #embed-optimizer-4b1647ded78fdafc89edd99a29b10f78 { min-height: 696px; } }
@media (600px < width <= 782px) { #embed-optimizer-4b1647ded78fdafc89edd99a29b10f78 { min-height: 333px; } }
@media (782px < width) { #embed-optimizer-4b1647ded78fdafc89edd99a29b10f78 { min-height: 337px; } }
</style>

✅ For Image Prioritizer, I see that it is populating the sizes as expected: https://complicated-lyrebird-c797ca.instawp.xyz/images-in-columns/

<img
  data-od-removed-fetchpriority="high"
  data-od-replaced-sizes="(max-width: 1024px) 100vw, 1024px"
  data-od-xpath="/HTML/BODY/DIV[@class=&#039;wp-site-blocks&#039;]/*[2][self::MAIN]/*[1][self::DIV]/*[3][self::DIV]/*[1][self::DIV]/*[1][self::DIV]/*[1][self::FIGURE]/*[1][self::IMG]"
  decoding="async"
  width="1024"
  height="673"
  src="https://complicated-lyrebird-c797ca.instawp.xyz/wp-content/uploads/2025/02/bison2-1024x673.jpg"
  alt=""
  class="wp-image-13"
  srcset="
    https://complicated-lyrebird-c797ca.instawp.xyz/wp-content/uploads/2025/02/bison2-1024x673.jpg  1024w,
    https://complicated-lyrebird-c797ca.instawp.xyz/wp-content/uploads/2025/02/bison2-300x197.jpg    300w,
    https://complicated-lyrebird-c797ca.instawp.xyz/wp-content/uploads/2025/02/bison2-768x505.jpg    768w,
    https://complicated-lyrebird-c797ca.instawp.xyz/wp-content/uploads/2025/02/bison2-1536x1010.jpg 1536w,
    https://complicated-lyrebird-c797ca.instawp.xyz/wp-content/uploads/2025/02/bison2-2048x1347.jpg 2048w
  "
  sizes="(width &lt;= 480px) 374px, (480px &lt; width &lt;= 600px) 524px, (600px &lt; width &lt;= 782px) 644px, (782px &lt; width) 136px"
/>

@westonruter
Copy link
Member

❌ For Optimization Detective, I discovered a bug where we missed URL-encoding the URLs in the imagesrcset of a Link response header. I've opened #1866 to fix the issue.

@westonruter
Copy link
Member

Account for 64 KiB limit for sending beacon data. (1851)

✅ With Optimization Detective, I've confirmed that when the URL Metric size exceeds 64 KiB that it is not attempted to be submitted: https://complicated-lyrebird-c797ca.instawp.xyz/200-images/

Image

Change minimum viewport width to be exclusive whereas the maximum width remains inclusive. (1839)

✅ Verified by looking at output of media queries above.

  • Disable URL Metric storage locking by default for administrators. (1835)

✅ Confirmed that when logged-in as an administrator that I am able to submit URL Metrics for each URL. However, when I am logged-out the storage lock is preventing me from submitting URL Metrics as expected:

Image

And if I try to force it by clearing the client-side lock, I get the expected 403 Forbidden:

Image

@westonruter
Copy link
Member

westonruter commented Feb 12, 2025

  • Include active plugins in ETag data and increase default freshness TTL from 1 day to 1 week. (1854)

✅ When I go to a post preview URL https://complicated-lyrebird-c797ca.instawp.xyz/?p=30&preview=true I can confirm that URL Metrics are not being collected:

Image

@github-project-automation github-project-automation bot moved this from Code Review 👀 to Done 😃 in WP Performance 2024 Feb 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Plugin] Performance Lab Issue relates to work in the Performance Lab Plugin only
Projects
Status: Done 😃
Development

Successfully merging a pull request may close this issue.

2 participants